811762 - Port ESR download page to Bedrock

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect, P3)

Description

[Alex Keybl [:akeybl]]

We need to create a https://www.mozilla.org/en-US/firefox/organizations/all17.html nearly identical to https://www.mozilla.org/en-US/firefox/organizations/all.html, but hooked up to product-details and bouncer for ESR17 specifically.

https://www.mozilla.org/en-US/firefox/organizations/faq/ would also need to change.
"Where can I download Mozilla Firefox ESR?

You can download Mozilla Firefox ESR here [https://www.mozilla.org/en-US/firefox/organizations/all.html]."

should be something like

"Where can I download Mozilla Firefox ESR?

You can download Mozilla Firefox ESR10 here [https://www.mozilla.org/en-US/firefox/organizations/all.html], and Firefox ESR17 here [https://www.mozilla.org/en-US/firefox/organizations/all17.html]."

Comment 1

[Alex Keybl [:akeybl]]

Alternatively, we could just add an ESR17 table to https://www.mozilla.org/en-US/firefox/organizations/all.html and not have differing download locations. That'd probably be easier (good idea Lukas).

Comment 2

[Laura Forrest]

Hey Mike -- Can you advise here? This would be needed for the Firefox 17 launch next Tuesday.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

I'm currently hardcoding all.html with an additional 17esr table, but for this release and the next we will need both FIREFOX_ESR_10 and FIREFOX_ESR_17 options for the downloads page and in productDetails.php and firefoxDetails.php -- will want to have the option to toggle between having 2 ESR releases available and 1 depending on where we are in the release cycle.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Hardcoding take one was 110928 and it was in the wrong place so I pushed a fix in 110932.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

And then r110950 for stage/production

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

This shouldn't be assigned to me, I can't make the proper php changes for generation of the all.html page with esr10 and esr17 side by side.  Anthony can you take this on or help find someone in webdev with time to make this minor change?

Comment 7

[Anthony Ricaud (:rik)]

Renaming to better reflect the work left to do.

What we need to do here is port the current page to Bedrock and add support for listing two ESR builds when needed.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

just updated with r111322 and r111323 to update the hardcoding for 17.0.1esr udpate.

Comment 9

[Elideb]

Currently there is no support for more than one ESR build in product details. To avoid manually hardcoding the download page every 10 months, why not add a new line

define('FIREFOX_ESR_QA',                           '17.0.2esr');

and modify the methods in firefox_details.class.php used to query FIREFOX_ESR to accept a parameter telling whether to use ESR or ESR_QA?
The hardest (most boring) part will be adding the new entries in firefox_details.

With a small modification export_json.php should be able to generate firefox_primary_builds.json and firefox_beta_builds.json with entries for 10.0.12esr and 17.0.2esr. The new version of all.html should only check which esr versions are available in primary and beta and display each on a different table (4 tops).

Comment 10

[Elideb]

Attachment: Update to product-details to manage up to two ESR versions

This patch adds a new entry in firefox_details.class.php for ESR versions in the Quality Assurance period.
It also modifies export_json.php so that it properly generates firefoxDetails.json and firefoxVersions.json with this data.

Also added ESR_QA entries for all locales with an ESR build, in both primary and beta builds.

Comment 11

[Elideb]

Attachment: Fix for organizations/all.html to display ESR and ESR_QA builds

Warning: So far I have been unable to get a version of the PHP site running locally, so this is untested. However, it gives an idea of how to approach the issue.
It relies on functionality added to firefoxDetails.class.php in the previous patch which _should_ work.

Patch to dynamically generate ESR_QA and ESR (primary and beta) tables, if both are available in product details. Remove hardcoded entries for 17.0.2 (ESR_QA).

Comment 12

[Elideb]

How is the work on this going? If all that is required is making an equivalent version of the new Languages page for ESR, I could get it done. The only problem is generating the data for the coming ESR version in the view and return the version numbers, but I think I can get that sorted.

Should I get to work on that?

Comment 13

[Elideb]

Attachment: product-details: new FIREFOX_ESR_QA version, plus corresponding builds

Updated patch to apply on svn.mozilla.org, modifying product-details.
Adds new firefox version FIREFOX_ESR_QA, which must be always present.
All languages with a 10.0.12esr build now have 17.0.2esr too. Please, review later as appropriate.

We need this change so we are able to detect if there is a QA version from bedrock's views.

Comment 14

[Elideb]

I have created a new Pull Request: https://github.com/mozilla/bedrock/pull/623/files

It creates a new firefox/organizations/all.html page in Bedrock wich displays at least the current ESR builds. If FIREFOX_ESR_QA builds are present in firefox_details.json, those builds are displayed as well, for a total of 4 tables (17.0.2esr, 10.0.12esr, beta 17.0.2esr and beta 10.0.12esr, in this order).

Comment 15

[Elideb]

I didn't mention it, but the old mozilla.org pages (pretty much the ones listed in bug 828050) should of course be confirmed to work with the additional entry in product_details. I've been unable to set up a local Apache version of the old site, so I couldn't test them myself.

Comment 16

[Andrei Hajdukewycz [:sancus]]

https://github.com/mozilla/bedrock/pull/623 was closed due to the new path we'd prefer for this page(and other all download pages) reflected in Bug 860865.

Comment 17

[Kohei Yoshino [:kohei]]

https://github.com/mozilla/bedrock/pull/1612