811815 - [Browser] A href links are not underlined/showing as links in Browser

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

## Environment :
Unagi phone, build 20121114
  
## Repro :
1. launch browser
2. go to http://people.mozilla.com/~nhirata/html_tp/AndroidLinks.html

## Expected :
1. A href links have an underline/color so it's easy to determine it's a link

## Actual :
1. it looks solid black.  Hard to tell they are links

## Note :
1. usability issue + I think this is a regression?

Comment 1

[Ben Francis [:benfrancis]]

This looks like a platform issue... I don't *think* this can be effected by a CSS issue in the browser app itself?

Comment 2

[Jason Smith [:jsmith]]

Definitely a regression also - I know this was working before.

Comment 5

[Doug Turner (:dougt)]

This was most likely caused by bug 799609.  Please see comment #4 where gal says that this is a v2 feature.  renom'ing for further consideration.

Comment 6

[Jason Smith [:jsmith]]

(In reply to Doug Turner (:dougt) from comment #5)
> This was most likely caused by bug 799609.  Please see comment #4 where gal
> says that this is a v2 feature.  renom'ing for further consideration.

Uhh...how is this a v2 feature when this was working before?

Comment 7

[Justin Lebar (not reading bugmail)]

> This was most likely caused by bug 799609.

"Link coloring" refers to coloring visited links purple.

I don't think bug 799609 is involved here.  Or, if it is, this is an entirely unexpected result, from at least my perspective.

Comment 8

[Justin Lebar (not reading bugmail)]

Again, this is an obvious blocker.  You do not have to look hard to find webpages which are rendered unusable by this bug.

Comment 9

[Jason Smith [:jsmith]]

(In reply to Justin Lebar [:jlebar] from comment #8)
> Again, this is an obvious blocker.  You do not have to look hard to find
> webpages which are rendered unusable by this bug.

+1

Comment 10

[Doug Turner (:dougt)]

so, this is about the links not being underlined (colorization is going to be busted for v.1)

Comment 11

[Justin Lebar (not reading bugmail)]

(In reply to Doug Turner (:dougt) from comment #10)
> so, this is about the links not being underlined (colorization is going to
> be busted for v.1)

The links should be underlined and blue, without places.  They're currently not underlined and black.

With places, a link should be underlined and blue or purple, depending on whether it has been visited.  Getting specifically this color-changing behavior is what we punted on.

Comment 12

[Doug Turner (:dougt)]

> I don't think bug 799609 is involved here.

fwiw, Enabling places fixes the problem.  Patching coming up to fix the default state/color of links.

Comment 13

[Doug Turner (:dougt)]

Attachment: patch v.1

i am not sure this is entirely correct.

To avoid risk, maybe we may want to just set self->mLinkState to eLinkState_Unvisited when mHistory is null.

Thoughts?

Comment 14

[Justin Lebar (not reading bugmail)]

> To avoid risk, maybe we may want to just set self->mLinkState to eLinkState_Unvisited 
> when mHistory is null.

Yeah, that seems safer, in terms of landing on Beta.

Also, I'm not familiar with this code; I'd prefer if bz reviewed.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 686236 [details] [diff] [review]
patch v.1

r=me.  This definitely makes sense: we're in Unknown, we know we have an href, so we have nothing to lose by going into Unvisited.

Comment 16

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7bb68db8ab5f

Comment 17

[Doug Turner (:dougt)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/977ff5b5a332
https://hg.mozilla.org/releases/mozilla-beta/rev/df0ed6a8b137

Comment 18

[Andrew Overholt [:overholt]]

Setting priority based on triage discussions.  Feel free to decrease priority if you disagree.

Comment 19

[Justin Lebar (not reading bugmail)]

This hasn't landed on m-c yet.

Comment 20

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Heh, my B.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7bb68db8ab5f