[Keyboard] Should use 2 tones, one for input keys and one for function keys

VERIFIED FIXED

Status

Firefox OS
Gaia::Keyboard
P3
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: patryk, Assigned: samjoch)

Tracking

unspecified
All
Other

Firefox Tracking Flags

(b2g18+)

Details

(Whiteboard: visual design, sound interaction, visual-tracking)

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 681641 [details]
Sounds

When a key is pressed there should be audio feedback. It would be great to have one tone for the keys and another for function keys like space, enter, shift, symbols and delete. See Attachment. I have 4 sound variations, these seemed to work best on device.
It feels like this bug has some collision with bug 811622
(Reporter)

Updated

5 years ago
Priority: -- → P3
Whiteboard: visual design, sound → visual design, sound, interaction

Updated

5 years ago
Component: Gaia::System → Gaia::System::Keyboard
(Reporter)

Comment 2

5 years ago
(In reply to Vivien Nicolas (:vingtetun) from comment #1)
> It feels like this bug has some collision with bug 811622

When clarified Larissa just states to move it to a different screen. We shouldn't remove the sounds, just give the option to the user to disable them if they deemed them annoying.

Comment 3

5 years ago
I just had a chat with Rudy and it looks like the sounds are in fact in place.   It should just be a matter of deciding if we want to have the setting enabled by default or not.

Also, the haptics are so delayed and low-quality they are more annoying than useful.  We should just remove it in my opinion.
Whiteboard: visual design, sound, interaction → visual design, sound, interaction, UX-P2
Has there been a decision made to remove or keep the sound? If we are keeping it - could we implement a single sound for all keys?
Flags: needinfo?(padamczyk)
(Reporter)

Comment 5

5 years ago
The sound for keys is in, I believe its disabled by default. But I'd want there to be 2 sounds. Since we're post v.1, I'll change the title, to reflect the original request be fully fulfilled.
Flags: needinfo?(padamczyk)
Summary: [Keyboard] Need Audio Feedback → [Keyboard] Should use 2 tones, one for input keys and one for function keys
Whiteboard: visual design, sound, interaction, UX-P2 → visual design, sound, UX-P3, v.1.1
(Reporter)

Updated

5 years ago
Whiteboard: visual design, sound, UX-P3, v.1.1 → visual design sound UX-P3 yedo

Updated

5 years ago
blocking-b2g: --- → leo?

Updated

5 years ago
blocking-b2g: leo? → ---
tracking-b2g18: --- → ?
Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1
tracking-b2g18: ? → +
Hi Casey, with Patryk on vacation, do you happen to know what the status of this bug is?
Flags: needinfo?(kyee)

Updated

5 years ago
Flags: needinfo?(kyee) → needinfo?(fdjabri)

Comment 8

5 years ago
Swapped Casey out for Francis on the needinfo, as Francis and Josh are working on keyboard efforts now.
(Assignee)

Updated

5 years ago
Assignee: nobody → sjochimek
Hi Eric, 

Patryk followed up with Sam Joch and Sam said he'll be working on it this week.
Flags: needinfo?(fdjabri)
(In reply to Francis Djabri [:djabber] from comment #9)
> Hi Eric, 
> 
> Patryk followed up with Sam Joch and Sam said he'll be working on it this
> week.

Great, thanks for letting me know Francis :)
(In reply to Eric Pang [:epang] from comment #10)
> (In reply to Francis Djabri [:djabber] from comment #9)
> > Hi Eric, 
> > 
> > Patryk followed up with Sam Joch and Sam said he'll be working on it this
> > week.
> 
> Great, thanks for letting me know Francis :)

Any updates for this bug Sam?  Francis mentioned you would be working on it last week.
Flags: needinfo?(sjochimek)

Updated

5 years ago
Whiteboard: visual design sound UX-P3 yedo → visual design, sound interaction, hanzo, visual-tracking

Updated

5 years ago
Whiteboard: visual design, sound interaction, hanzo, visual-tracking → visual design, sound interaction, visual-tracking
(Reporter)

Comment 13

5 years ago
Great. Ship it.
(Assignee)

Updated

5 years ago
Attachment #752170 - Flags: review?(21)
(Assignee)

Updated

5 years ago
Attachment #752170 - Flags: review?(21) → review?(timdream)
Comment on attachment 752170 [details]
PR on Github

One of the thing to consider would be put the |isSpecialKey| into |triggerFeedback()|, but that's not that important I guess.
Attachment #752170 - Flags: review?(timdream) → review+
https://github.com/mozilla-b2g/gaia/commit/92b7375a6e0310a09fb2c2087b7b68b1cbfe94d3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Attachment #752170 - Flags: feedback?(padamczyk) → feedback+
Naoki, can you help verify?  Once verified we can flag for approval.  Thanks!
Flags: needinfo?(nhirata.bugzilla)
Verified: 
## Environment :
"mozilla-central" path="gecko" revision="68760713a30f"
"gecko" revision="64b502c512a059c58da80924968136713fe6f8c3"
"gaia.git" revision="30f31d7dc5f81eb0c0e7980c44aad3b0a56f5a9c"
Build ID: 2013-06-13-03-08-19
MC/master build
Unagi

Verified... 

I am not sure if I understand the code, are we allocating new memory space for both sound bytes when any key is pressed?  I'm showing a lag if I type fast more so than before with the sound byte turned on.  I'm also worried about memory.
Flags: needinfo?(nhirata.bugzilla)
Flags: needinfo?(alive)
Flags: needinfo?(alive) → needinfo?(timdream)
Status: RESOLVED → VERIFIED
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #17)
> I am not sure if I understand the code, are we allocating new memory space
> for both sound bytes when any key is pressed?  I'm showing a lag if I type
> fast more so than before with the sound byte turned on.  I'm also worried
> about memory.

Are you sure that the lag was introduced in this bug? If so please filing a bug so people could work on that. We might need to downgrade the bitrate of the files I think.
Flags: needinfo?(timdream)
You need to log in before you can comment on or make changes to this bug.