811915 - Update gaia CSS for "-moz-placeholder" pseudo-class to pseudo-element conversion

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 737786 landed on trunk a few days ago, converting -moz-placeholder from a pseudo-class to a pseudo-element.

As a result, we now get this output for some Gaia CSS in logcat:

JavaScript Warning: "This pseudo-element must use the "::" form: '-moz-placeholder'.  Ruleset ignored due to bad selector." {file: "app://homescreen.gaiamobile.org/shared/style/input_areas.css" line: 38}

...for this chunk of style:
> input[type="text"]:-moz-placeholder,
> input[type="password"]:-moz-placeholder,
> input[type="email"]:-moz-placeholder,
> input[type="tel"]:-moz-placeholder,
> input[type="search"]:-moz-placeholder,
> textarea:-moz-placeholder {
>   color: #666;
> }
https://github.com/mozilla-b2g/gaia/blob/master/shared/style/input_areas.css#L38

So that chunk of CSS is getting ignored for B2G builds with bug 737786 (which is just trunk builds -- gecko ver 19 and greater -- right now).

Perhaps we should duplicate that chunk of CSS with "::" instead of ":" -- without digging in too deeply, I suspect that might address this for both old builds and new builds. CC'ing mounir for confirmation.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

it's easy for me ... I just need a confirm :)

Comment 2

[Mounir Lamouri (:mounir)]

Daniel, B2G is using m-a and this has landed on m-c so I don't think it sholud affect test drivers or even v1. This said, we should fix that given that we will be back on central at some point but I doubt gaia will make this a priority given how overloaded the team is.

Comment 3

[Daniel Holbert [:dholbert]]

Sorry -- I reported using the "report-a-bug-uncovered-while-dogfooding" mz.la link, which has some keywords pre-populated. Removed testdrivers,unagi  keywords now.

Agreed this isn't a priority at the moment; I just ran across it & wanted to make sure it was tracked somewhere.

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> Agreed this isn't a priority at the moment; I just ran across it & wanted to
> make sure it was tracked somewhere.

I should actually, have done that myself. Thanks for filing the bug.

Vivien, is there anything to do to mark a bug as "to fix after the rush"?

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I can change all pseudo-classes to pseudo-elements in /apps and /shared folder in gaia.
is this OK for you guys?

Comment 6

[Mounir Lamouri (:mounir)]

If you fix that, you should also fix things that do:
input:not([type="radio"]):-moz-placeholder,
to make them do:
::-moz-placeholder {
(the pseudo-class never applied on non-textfields)

Also, if possible, you might just remove the :-moz-placeholder CSS rules because the placeholder color should be "the right thing", now.

Comment 7

[Mounir Lamouri (:mounir)]

I think this should be fixd on Gaia trunk. The next FxOS version not based on Gecko 18 will need to have that bug fixed.

Comment 8

[BMO Automation]

Firefox OS is not being worked on