811934 - [e.me][everything.me][evme] After running the RottenTomatoes e.me app, e.me no longer appears

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P1)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

## Environment :
Unagi phone, build 20121114
  
## Repro :
1. swipe to everything.me screen
2. select movies -> Rottentomates
3. set remember my choice to off for geolocation for homescreen 
4. select allow
5. swipe to the landing page and swipe back

## Expected :
1. rotten tomatoes webapp

## Actual :
1. e.me completely disappears, long tapping on home shows nothing; no wrapper is shown

## Note :

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It looks like it's geolocation related, and probably a dup of bug 803615?

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Is there some sort of debug flag I can turn on to see what's going on better in logcat?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

What I don't understand in those steps to reproduce is between 4 and 5. Does the application is not on the foreground anymore?

Also when you say e.me dissapears, do you mean the search page on the left side of the homescreen?

Comment 4

[Alex Keybl [:akeybl]]

Marking for C2, given this meets the criteria of known P1/P2 blocking-basecamp+ bugs at the end of C1.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Ok I can reproduce and this sounds really bad.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This code add a timeout of 2 seconds on the geolocation returns. Otherwise we wait forever. It also cancel the current action if the user returns to the homescreen in the 2 seconds interval.

Comment 7

[Cristian Rodriguez (:crdlc)]

Comment on attachment 685629 [details] [diff] [review]
Patch

> this.cancel = function() {

Please add name to the function because I requested to Ran to delete anonymous function in all code :) We need give example jjaja

Comment 8

[Cristian Rodriguez (:crdlc)]

what is the branch to test? the code is OK for me

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to crdlc from comment #8)
> what is the branch to test? the code is OK for me

The branch is at: https://github.com/vingtetun/gaia/tree/811934

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/c778f72ac3c4d788885562cee5a4b44345c32956

Comment 11

[John Hammink]

Unfortunately I cannot test this because rotten tomatoes app currently appears to crash on launch (if "remember my choice" is unselected".  

https://bugzilla.mozilla.org/show_bug.cgi?id=818201

Comment 12

[John Hammink]

Ahh, well, it doesn't crash actually - it just doesn't launch.   Is it possible to test this fix WITHOUT enabling "remember my choice"?

Comment 13

[isabelrios]

2012/28/01 build. Gecko-cfad7c9 Gaia-6c53dfd