811943 - File list not showing files with same basename but different URI

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect)

Description

[Gregory Szorc [:gps]]

I went in for my first chrome debugging session. It was all unicorns and rainbows. Then, when I needed to load up a "main.js" file, there was only a single "main.js" in the drop-down file list and it wasn't the one I was interested in. Strangely, a few sessions later the "main.js" was the one I was interested in.

I'm guessing the drop-down de-duplicates based on the file's basename (as opposed to its URI or full path). It probably shouldn't do that. It should probably even provide some way to disambiguate between files that share names. But, I'm not a designer, so I dunno. I just want it to show ALL OF THE FILES.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

It actually stores each URI in a separate entry, but tries to disambiguate files with the same name by producing unique labels, like main.js, /foo/main.js, etc. We need specific steps to reproduce this in order to investigate further.

Comment 2

[Victor Porof [:vporof][:vp]]

I would assume that the order of loading the "main.js" sources was reversed. So in the case of files that share names, if, for example, we'd first get a foo/bar/main.js and after that a baz/main.js, the sources menulist would show:

- main.js
- baz/main.js

However, if we were notified about the scripts in the reverse order, then the sources menulist would show:

- main.js
- foo/bar/main.js

Comment 3

[Gregory Szorc [:gps]]

Load order isn't consistent, especially when doing chrome debugging. I would much prefer for scripts sharing a basename to have some additional identifying info to help identify them.

As for reproduce steps, I reproduced by having an about: page with a main.js. This was shared with Sync's main.js. So, STR should be to add two dummy JSMs in the tree foo.jsm and bar/foo.jsm then have them loaded and launch the chrome debugger.

Comment 4

[Victor Porof [:vporof][:vp]]

One possible (and easiest to address imho) solution would be change all entries to incrementally add path parts when names collide. So, following the example above:

1] we get notified about foo/bar/main.js
   menulist contains: main.js
2] we get notified about baz/main.js
   menulist contains: foo/bar/main.js and baz/main.js

Does that sound ok, Panos?

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

This reported problem wasn't about the order of scripts with the same basename, but about scripts missing from the list. The suggestion in comment 3 describes a way to get into such a state, so we need to generate a patch and build Firefox with that. Gregory if you already have a patch like that, it would be very helpful to post it here.

Comment 6

[Anton Kovalyov (:anton)]

We couldn't reproduce it. Could you please verify that the bug is still present and give us your steps to reproduce? Thanks!

Comment 7

[Rob Campbell [:rc] (:robcee)]

not reproducible.

Comment 8

[Victor Porof [:vporof][:vp]]

In any case, bug 812083 would most likely fix this.