812034 - Permissions: Connect access field for permission checks

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

Currently we are still checking the base permission name for device-storage. With this patch we check for the access field as well.

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[David Dahl :ddahl]

Comment on attachment 681801 [details] [diff] [review]
patch

Review of attachment 681801 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good

::: b2g/components/ContentPermissionPrompt.js
@@ -91,5 @@
>  
>        if (evt.detail.type == "permission-allow") {
>          if (evt.detail.remember) {
>            rememberPermission(request.type, request.principal);
> -          Services.perms.addFromPrincipal(request.principal, request.type,

hmm. was this just duplicating "rememberPermission"? I think I did that. not good.

Comment 3

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c3ec1f82732

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0c3ec1f82732

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fba069d27d6b
https://hg.mozilla.org/releases/mozilla-beta/rev/3b126aa60bb9

Comment 6

[Jason Smith [:jsmith]]

Verified during the work week by doing such tests such as:

Test that I can read all of my pictures, music, sdcard, and videos in the device storage API with read access granted to the privileged app

Test that I can read all of my contacts in the contacts API with read access granted to the privileged app

Test that I can fail to read all of my  pictures, music, sdcard, and videos in the device storage API with create access granted to the privileged app

Test that I can fail to read all of my contacts in the contacts API with create only access to the privileged app