Closed
Bug 812119
Opened 12 years ago
Closed 12 years ago
[HOMESCREEN] Must reboot after deleting an app to see its icon disappear from homescreen
Categories
(Core Graveyard :: DOM: Apps, defect, P1)
Tracking
(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)
People
(Reporter: dscravaglieri, Assigned: vingtetun)
References
Details
(Keywords: smoketest)
Attachments
(1 file)
3.63 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
gecko-aurora: 0d76df6f808d
gaia: 487a7c18c8ff08db7d2e76239e85e3e5eefcc8b7
Install an app from Marketplace
Open the app
Close the app
Delete the app
Expected:
Icon disappear from homescreen
Actual:
Icon still in home screen, must reboot.
Reporter | ||
Updated•12 years ago
|
blocking-basecamp: ? → +
Priority: -- → P2
Comment 1•12 years ago
|
||
I did some debugging, and I found that app.manifestURL is undefined here, so we're never getting any icons to remove:
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid.js#L853
Perhaps this is a problem with the event navigator.mozApps.mgmt.onuninstall is getting?
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → philipp
Comment 2•12 years ago
|
||
Marking for C2, given this meets the criteria of known P1/P2 blocking-basecamp+ bugs at the end of C1.
Target Milestone: --- → B2G C2 (20nov-10dec)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #684019 -
Flags: review?(fabrice)
Comment 4•12 years ago
|
||
Comment on attachment 684019 [details] [diff] [review]
Patch
Review of attachment 684019 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/apps/src/Webapps.js
@@ +753,2 @@
> let event = new this._window.MozApplicationEvent("applicationuninstall",
> + { application : createApplicationObject(this._window, detail) });
You can just pass |msg| here and not care create the extra |detail| object I think.
Attachment #684019 -
Flags: review?(fabrice) → review+
Updated•12 years ago
|
Component: Gaia::Homescreen → DOM: Apps
Product: Boot2Gecko → Core
Version: unspecified → Trunk
Comment 5•12 years ago
|
||
After addressing Fabrice's comment, is this patch ready to land?
Comment 7•12 years ago
|
||
I just decided to land this with Fabrice's comment addressed (I tested locally to make sure it worked):
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f7114a9d050
Assignee: philipp → 21
Comment 8•12 years ago
|
||
Sorry, had to back this out for mochitest-other failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/822a1cfc322d
https://tbpl.mozilla.org/php/getParsedLog.php?id=17435308&tree=Mozilla-Inbound
3385 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/docshell/test/chrome/test_bug454235.xul | offscreen browser is not visible
9695 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/localstorage/test_app_uninstall.html | Test timed out.
9698 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/localstorage/test_clear_browser_data.html | no data - got bar, expected null
9700 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/localstorage/test_clear_browser_data.html | no data - got bar, expected null
9716 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/localstorage/test_clear_browser_data.html | Test timed out.
9730 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_bug_765063.xul | Test timed out.
9733 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_bug_795164.xul | Test timed out.
9734 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | 4 test timeouts, giving up.
9735 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | Skipping 449 remaining tests.
9736 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_bug_795164.xul finished in a non-clean fashion, probably because it didn't call SimpleTest.finish()
Comment 9•12 years ago
|
||
This also had a Linux bc failure.
https://tbpl.mozilla.org/php/getParsedLog.php?id=17435568&tree=Mozilla-Inbound
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/dom/tests/browser/browser_webapps_permissions.js | Test timed out
Comment 12•12 years ago
|
||
Raising priority for smoketest blocker and to get this one back on the radar since it was backed out.
Priority: P2 → P1
Assignee | ||
Comment 13•12 years ago
|
||
(In reply to Dylan Oliver [:doliver] from comment #12)
> Raising priority for smoketest blocker and to get this one back on the radar
> since it was backed out.
I found the cause of failures. I sent a version on tre try to see how it performs.
Assignee | ||
Comment 14•12 years ago
|
||
Status: NEW → ASSIGNED
Comment 15•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 16•12 years ago
|
||
Comment 17•12 years ago
|
||
Verified through smoke tests + gaia ui test automation.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•