Closed Bug 812203 Opened 7 years ago Closed 7 years ago

crash in nsHttpConnection::SetSecurityCallbacks

Categories

(Core :: Networking: HTTP, defect, critical)

19 Branch
All
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- unaffected
firefox19 + verified

People

(Reporter: scoobidiver, Assigned: jdm)

References

Details

(Keywords: crash, regression, topcrash)

Crash Data

Attachments

(1 file)

It first showed up in 19.0a1/20121115. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dd68409d7810&tochange=a761bfc192b5
It's likely a regression from bug 804655.

Signature 	mozilla::BaseAutoLock<mozilla::Mutex>::BaseAutoLock<mozilla::Mutex>(mozilla::Mutex&) More Reports Search
UUID	996b4b96-b7e2-4c52-962c-282582121115
Date Processed	2012-11-15 15:43:57
Uptime	87
Last Crash	3.9 weeks before submission
Install Age	1.4 minutes since version was first installed.
Install Time	2012-11-15 15:42:13
Product	Firefox
Version	19.0a1
Build ID	20121115030705
Release Channel	nightly
OS	Windows NT
OS Version	6.1.7601 Service Pack 1
Build Architecture	x86
Build Architecture Info	GenuineIntel family 6 model 15 stepping 13
Crash Reason	EXCEPTION_ACCESS_VIOLATION_READ
Crash Address	0x3c
App Notes 	
AdapterVendorID: 0x8086, AdapterDeviceID: 0x2a42, AdapterSubsysID: 018b1631, AdapterDriverVersion: 8.15.10.2302
D2D? D2D+ DWrite? DWrite+ D3D10 Layers? D3D10 Layers+ 
EMCheckCompatibility	True
Adapter Vendor ID	0x8086
Adapter Device ID	0x2a42
Total Virtual Memory	2147352576
Available Virtual Memory	1692164096
System Memory Use Percentage	57
Available Page File	2852679680
Available Physical Memory	1325322240

Frame 	Module 	Signature 	Source
0 	xul.dll 	mozilla::BaseAutoLock<mozilla::Mutex>::BaseAutoLock<mozilla::Mutex> 	obj-firefox/dist/include/mozilla/Monitor.h:92
1 	xul.dll 	nsHttpConnection::SetSecurityCallbacks 	netwerk/protocol/http/nsHttpConnection.cpp:1033
2 	xul.dll 	nsHttpConnectionMgr::nsConnectionHandle::SetSecurityCallbacks 	netwerk/protocol/http/nsHttpConnectionMgr.h:356
3 	xul.dll 	nsHttpTransaction::SetSecurityCallbacks 	netwerk/protocol/http/nsHttpTransaction.cpp:409
4 	xul.dll 	mozilla::net::nsHttpChannel::UpdateAggregateCallbacks 	netwerk/protocol/http/nsHttpChannel.cpp:5938
5 	xul.dll 	mozilla::net::nsHttpChannel::SetNotificationCallbacks 	netwerk/protocol/http/nsHttpChannel.cpp:5960
6 	xul.dll 	imgRequest::Init 	image/src/imgRequest.cpp:152
7 	xul.dll 	imgCacheValidator::OnStartRequest 	image/src/imgLoader.cpp:2182
8 	xul.dll 	mozilla::net::nsHttpChannel::CallOnStartRequest 	netwerk/protocol/http/nsHttpChannel.cpp:953
9 	xul.dll 	mozilla::net::nsHttpChannel::InitCacheEntry 	netwerk/protocol/http/nsHttpChannel.cpp:3566
10 	xul.dll 	xul.dll@0x2cd00f 	
11 	xul.dll 	mozilla::net::nsHttpChannel::ProcessNormal 	netwerk/protocol/http/nsHttpChannel.cpp:1379
12 	xul.dll 	nsHttpChannelAuthProvider::Release 	netwerk/protocol/http/nsHttpChannelAuthProvider.cpp:1430
13 	xul.dll 	mozilla::net::nsHttpChannel::ProcessResponse 	netwerk/protocol/http/nsHttpChannel.cpp:1214
14 	xul.dll 	mozilla::net::nsHttpChannel::OnStartRequest 	netwerk/protocol/http/nsHttpChannel.cpp:4808
15 	xul.dll 	nsInputStreamPump::OnStateStart 	netwerk/base/src/nsInputStreamPump.cpp:417
16 	xul.dll 	nsInputStreamPump::OnInputStreamReady 	netwerk/base/src/nsInputStreamPump.cpp:368
17 	xul.dll 	nsInputStreamReadyEvent::Run 	xpcom/io/nsStreamUtils.cpp:82
18 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:627
19 	xul.dll 	NS_ProcessNextEvent_P 	obj-firefox/xpcom/build/nsThreadUtils.cpp:221
20 	xul.dll 	nsXMLHttpRequest::Send 	content/base/src/nsXMLHttpRequest.cpp:3137
21 	xul.dll 	nsXMLHttpRequest::Send 	content/base/src/nsXMLHttpRequest.h:354
22 	xul.dll 	nsXMLHttpRequest::Send 	content/base/src/nsXMLHttpRequest.h:373
23 	xul.dll 	mozilla::dom::XMLHttpRequestBinding::send 	obj-firefox/dom/bindings/XMLHttpRequestBinding.cpp:641
24 	xul.dll 	mozilla::dom::XMLHttpRequestBinding::genericMethod 	obj-firefox/dom/bindings/XMLHttpRequestBinding.cpp:1180
25 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:369
...

More reports at:
https://crash-stats.mozilla.com/report/list?signature=mozilla%3A%3ABaseAutoLock%3Cmozilla%3A%3AMutex%3E%3A%3ABaseAutoLock%3Cmozilla%3A%3AMutex%3E%28mozilla%3A%3AMutex%26%29
https://crash-stats.mozilla.com/report/list?signature=nsHttpConnection%3A%3ASetSecurityCallbacks%28nsIInterfaceRequestor*%29
Sigh. This is missing a null check for SetSecurityCallbacks in NS_DECL_NSAHTTPCONECTION in nsAHttpConnection.h.
Keywords: topcrash
After searching a search engine flew on this page
http://www.eldorado.ru/cat/3183214/3183969/?filter_3183958[7098]=on
Comment on attachment 682075 [details] [diff] [review]
Ensure we don't try to set security callbacks on missing connections.

Review of attachment 682075 [details] [diff] [review]:
-----------------------------------------------------------------

Ups, I had to catch this...

r=honzab
Attachment #682075 - Flags: review?(honzab.moz) → review+
Crash Signature: [@ mozilla::BaseAutoLock<mozilla::Mutex>::BaseAutoLock<mozilla::Mutex>(mozilla::Mutex&)] [@ nsHttpConnection::SetSecurityCallbacks(nsIInterfaceRequestor*)] → [@ mozilla::BaseAutoLock<mozilla::Mutex>::BaseAutoLock<mozilla::Mutex>(mozilla::Mutex&)] [@ nsHttpConnection::SetSecurityCallbacks(nsIInterfaceRequestor*)] [@ mozilla::MonitorAutoLock::MonitorAutoLock(mozilla::Monitor&)]
Crash Signature: [@ mozilla::BaseAutoLock<mozilla::Mutex>::BaseAutoLock<mozilla::Mutex>(mozilla::Mutex&)] [@ nsHttpConnection::SetSecurityCallbacks(nsIInterfaceRequestor*)] [@ mozilla::MonitorAutoLock::MonitorAutoLock(mozilla::Monitor&)] → [@ mozilla::BaseAutoLock<mozilla::Mutex>::BaseAutoLock<mozilla::Mutex>(mozilla::Mutex&)] [@ nsHttpConnection::SetSecurityCallbacks(nsIInterfaceRequestor*)] [@ mozilla::MonitorAutoLock::MonitorAutoLock(mozilla::Monitor&)] [@ nsHttpTransaction::SetSecuri…
Assignee: nobody → josh
https://hg.mozilla.org/mozilla-central/rev/fd7927a8baf8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Duplicate of this bug: 812026
This is no longer a topcrash, but it's still reproducing:
mozilla::BaseAutoLock<mozilla::Mutex>::BaseAutoLock<mozilla::Mutex>(mozilla::Mutex&) - 1 crash on the 01/24 Aurora https://crash-stats.mozilla.com/report/list?query_search=signature&query_type=contains&reason_type=contains&range_value=4&range_unit=weeks&hang_type=any&process_type=any&signature=mozilla%3A%3ABaseAutoLock%3Cmozilla%3A%3AMutex%3E%3A%3ABaseAutoLock%3Cmozilla%3A%3AMutex%3E%28mozilla%3A%3AMutex%26%29

nsHttpConnection::SetSecurityCallbacks(nsIInterfaceRequestor*), nsHttpTransaction::SetSecurityCallbacks(nsIInterfaceRequestor*) - no recent crashes https://crash-stats.mozilla.com/report/list?query_search=signature&query_type=contains&reason_type=contains&range_value=4&range_unit=weeks&hang_type=any&process_type=any&signature=nsHttpConnection%3A%3ASetSecurityCallbacks%28nsIInterfaceRequestor%2A%29
https://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&query=nsHttpTransaction%3A%3ASetSecurityCallbacks%28nsIInterfaceRequestor%2A%29&reason_type=contains&date=01%2F31%2F2013%2013%3A10%3A26&range_value=4&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=nsHttpTransaction%3A%3ASetSecurityCallbacks%28nsIInterfaceRequestor%2A%29

mozilla::MonitorAutoLock::MonitorAutoLock(mozilla::Monitor&) - 3 new crashes on Firefox 19 beta https://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&query=mozilla%3A%3AMonitorAutoLock%3A%3AMonitorAutoLock%28mozilla%3A%3AMonitor%26amp%3B%29&reason_type=contains&date=01%2F31%2F2013%2013%3A10%3A25&range_value=4&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=mozilla%3A%3AMonitorAutoLock%3A%3AMonitorAutoLock%28mozilla%3A%3AMonitor%26%29
Scoobidiver, any thoughts on comment 8?
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #9)
> Scoobidiver, any thoughts on comment 8?
There are indeed remaining crashes but they are a very low volume. I don't think it's worth a new bug.
Given the reduction in volume I'm marking this fx19:verified. Please add the verifyme keyword if there's something more you'd like tested.
You need to log in before you can comment on or make changes to this bug.