812245 - [Sound] Shut Down Animation Needs a sound

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P3)

Description

[Patryk Adamczyk [:patryk] UX]

Waiting for the sound from the vendor

Comment 1

[Patryk Adamczyk [:patryk] UX]

Attachment: Final Sound

Comment 2

[Patryk Adamczyk [:patryk] UX]

Would be nice if the shutdown sound was sync'd with the animation.

Comment 3

[Sam Joch [:samjoch]]

Attachment: Branch on github

Comment 4

[Sam Joch [:samjoch]]

Patryk: I added a 500 delay. The sound start when the first Orange circle appears.

Comment 5

[Patryk Adamczyk [:patryk] UX]

Tested, great! Ship it!

Comment 6

[Sam Joch [:samjoch]]

Attachment: PR Github

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 749001 [details]
PR Github

Why do you need the that 500 sec?

(set the review flag back to me when this question is answered)

Comment 8

[Patryk Adamczyk [:patryk] UX]

Comment on attachment 745845 [details]
Branch on github

Just tested it works perfectly.

Comment 9

[Sam Joch [:samjoch]]

Comment on attachment 749001 [details]
PR Github

Tim: We wanted this sound starts at the same time as the first orange circle appear. That explains the 500ms delay. If we don't use a delay here the sounds are played earlier, and the effect is broken.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 749001 [details]
PR Github

Hum...

1. Instead of introducing a timeout, please put the play() somewhere here:

https://github.com/samjoch/gaia/blob/793df1b47956b67a2ddc26008c54a1419d7e39c4/apps/system/js/sleep_menu.js#L279

So that the sound actually plays when the animation took place.

2. Do we really want to play that sound even with a partner shutdown video replace the default 3-ring animation?

Comment 11

[Sam Joch [:samjoch]]

Tim: Even if i put the play() in that part, i still need a timeout to play the sound to keep synchronized the sound and the animation. Without the timeout the sound is played when the animation start, too soon. Maybe we can add that delay in the sound ?

Patryk: Can you take 2. ?

Comment 12

[Patryk Adamczyk [:patryk] UX]

> 2. Do we really want to play that sound even with a partner shutdown video
> replace the default 3-ring animation?
Since we are allowing partners to swap out the animation we should also allow them to swap out the sound as well. Both the sound and the animation should be swap-able. 

I am okay if the animation and sound are locked together as 1 component.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 749001 [details]
PR Github

https://github.com/samjoch/gaia/blob/817a0347bbdace160cb2643d0ad82db24dadc76e/apps/system/js/sleep_menu.js#L291

As I said previously, instead of a timeout(), you should put the code in the nextAnimation() with condition checks, so the file would play at the exact time.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 749001 [details]
PR Github

You are getting there!

Comment 15

[Sam Joch [:samjoch]]

Ok i removed the setTimeout. Patryk can you confirm is still ok ?

Comment 16

[Patryk Adamczyk [:patryk] UX]

Looks good, still in sync. Ship it.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 749001 [details]
PR Github

Thank you!

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/e4bf807f22dd5c392d181a216b2e7d4ccd162308

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

The audio scares me with a large volume.
Could we lower the volume factor to 0.5 or else?

Or we should consider to change the default content/normal volume...

Comment 20

[Sam Joch [:samjoch]]

Revert from #883090:
https://github.com/mozilla-b2g/gaia/commit/586529fb54eae68e7854509b43fd87080cfcc606