Closed
Bug 81227
Opened 23 years ago
Closed 23 years ago
Switch to HTML mode and back to normal generates 3 Undo transactions
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: glazou, Assigned: cmanske)
References
Details
Attachments
(2 files)
5.60 KB,
patch
|
Details | Diff | Splinter Review | |
5.59 KB,
patch
|
Details | Diff | Splinter Review |
a) open a new Composer window b) switch to HTML mode c) switch back to normal mode d) dump Undo stack result : ---------------------- BEGIN UNDO STACK DUMP <!-- Bottom of Stack --> + SetDocTitleTxn: | + InsertElementTxn + PlaceholderTxn: + SetDocTitleTxn: | + InsertElementTxn <!-- Top of Stack --> Num Undo Items: 3 ---------------------- END UNDO STACK DUMP I think that 3 is a lot... I detected that in the CSSization of Composer because I was setting a bgcolor, looking at the markup and trying to Undo, without success. I don't think that moving from normal to HTML mode should generate a Txn ; and I can understand than switching back generates one and only Txn. But why 3 ?-) And why does it set the title ?
Assignee | ||
Comment 1•23 years ago
|
||
Fix is ready. Benefits are great: If no change is made in HTML Source, we don't generate any transactions, and thus we can retain the selection in Normal mode. Thus HTML source can be used to view your document source, and returning to normal is much faster (doesn't bother to rebuild the document. Also, the document modified state is now known correctly, so we don't have to force it to be "dirty" when editing source, as we do now.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Assignee | ||
Comment 4•23 years ago
|
||
r=mjudge, sr=kin
Whiteboard: FIX IN HAND need r=, sr= → FIX IN HAND
Assignee | ||
Comment 5•23 years ago
|
||
Assignee | ||
Comment 6•23 years ago
|
||
Checked in.
Hi Daniel, if you can please verify this one in latest build and mark verified-fixed.. thanks.
Reporter | ||
Comment 8•23 years ago
|
||
verified in windows and linux 20010625 builds
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•