Open Bug 812346 Opened 12 years ago Updated 2 years ago

Upgrade IsSafeToRunScript assertion to fatal

Categories

(Core :: DOM: Events, defect, P5)

Product:
Core
Component:
DOM: Events
Type:
defect

Tracking

()

People

(Reporter: jruderman, Unassigned)

References

(Depends on 1 open bug)

Details

(Split from bug 804814 comment 2)

###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file content/events/src/nsEventDispatcher.cpp, line 513

Smaug says this assertion should be changed from non-fatal to fatal.  It's currently NS_ERROR, so I think the fatal equivalent is MOZ_NOT_REACHED.

This change may make some (intermittent?) failures abort the test suite.  You'll want to at least make sure bug 735966 and bug 738803 are taken care of before landing this change.  Unless landing this change will help us get stacks or something.
Note that MOZ_NOT_REACHED also aborts in opt builds.
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.