window tests are not properly waiting for full cleanup before other window tests are run

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: erikvold, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

165 bytes, text/html
mossop
: review+
Details
This was causing an issue landing the patch for bug 803065 so I had to hack around the issue for a quick fix with https://github.com/erikvold/jetpack-sdk/commit/96d7cb0b51486048ade4437414e77437c46a4b5d  the better fix is obviously to fix all of the other tests, but that will take much more time.
Dave said he has something that might help with this. Ccing him for posterity.
Priority: -- → P1
I was thinking of the fixes that are now in bug 819587 but looks like they aren't window tests.
Blocks: 839997
Created attachment 737756 [details]
Pull request 944

Here is a patch that may fix various intermittent we are seeing.

We will most likely want to fix test that are just calling close without waiting for any event... (if there is any?)
Attachment #737756 - Flags: review?(evold)
Attachment #737756 - Flags: review?(evold) → review+

Comment 4

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/ccd30b439997ec1081e596d16ca3e4a5f34c041a
Bug 812417: Listen for domwindowclosed instead of unload when closing a
toplevel window.

https://github.com/mozilla/addon-sdk/commit/b7111ece7367bea97d1582b935cd6bca2101fc85
Merge pull request #944 from ochameau/bug812417

Bug 812417: Listen for domwindowclosed instead of unload when closing a toplevel window. r=@erikvold

Comment 5

5 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/053d759deab7b4fb5964f0d9e46b46a8f4519901
Backout bug 812417 "Pull request #944 from ochameau/bug812417"

This reverts commit b7111ece7367bea97d1582b935cd6bca2101fc85, reversing
changes made to 8ba3879d832ecb554e27147e77bd4060b5bb70b8.
Created attachment 738175 [details]
Pull request 948

The issue was that we were closing a child window in private browsing test.
I introduce a getToplevelWindow helper and use that in close() in order to ensure checking for the toplevel window when listening for domwindowclosed event.
Attachment #737756 - Attachment is obsolete: true
Attachment #738175 - Flags: review?(evold)
Attachment #738175 - Flags: review?(evold) → review+

Comment 7

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/2c9bff26b5a8ce39ea2b5690a3c7d5a26c026e80
Bug 812417: Listen for domwindowclosed instead of unload when closing a toplevel window.

https://github.com/mozilla/addon-sdk/commit/c9afeec18e22101c5f90f4773caac4cb98a9a9d7
Merge pull request #948 from ochameau/bug812417-2

Bug 812417: Listen for domwindowclosed instead of unload when closing a toplevel window. r=@mossop
I'm going through the list of open bugs that github robot has commented in. Is this bug fixed, Alex?
Flags: needinfo?(poirot.alex)
Looks like it.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(poirot.alex)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.