812510 - balrog failing tests on jenkins

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Ever since https://github.com/mozilla/balrog/commit/2a0829fba56e2aeac94cf1493bcd93cd4ccd4f75 we've been getting a bunch of
ERROR: Failure: TypeError ('module' object is not callable)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tmp.zlWuzbyfyk/lib/python2.6/site-packages/nose/loader.py", line 382, in loadTestsFromName
    addr.filename, addr.module)
  File "/tmp/tmp.zlWuzbyfyk/lib/python2.6/site-packages/nose/importer.py", line 39, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/tmp/tmp.zlWuzbyfyk/lib/python2.6/site-packages/nose/importer.py", line 86, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/var/lib/jenkins/jobs/Balrog/workspace/auslib/test/admin/views/test_base.py", line 1, in <module>
    from auslib.test.admin.views.base import ViewTest
  File "/var/lib/jenkins/jobs/Balrog/workspace/auslib/test/admin/views/base.py", line 6, in <module>
    from auslib.admin.base import app, db
  File "/var/lib/jenkins/jobs/Balrog/workspace/auslib/admin/base.py", line 4, in <module>
    from auslib.db import AUSDatabase
  File "/var/lib/jenkins/jobs/Balrog/workspace/auslib/db.py", line 12, in <module>
    import migrate.versioning.schema
  File "/var/lib/jenkins/jobs/Balrog/workspace/vendor/lib/python/migrate/versioning/schema.py", line 16, in <module>
    from migrate.versioning.repository import Repository
  File "/var/lib/jenkins/jobs/Balrog/workspace/vendor/lib/python/migrate/versioning/repository.py", line 13, in <module>
    from migrate.versioning import version, pathed, cfgparse
  File "/var/lib/jenkins/jobs/Balrog/workspace/vendor/lib/python/migrate/versioning/version.py", line 10, in <module>
    from migrate.versioning import pathed, script
  File "/var/lib/jenkins/jobs/Balrog/workspace/vendor/lib/python/migrate/versioning/pathed.py", line 11, in <module>
    from migrate.versioning.util import KeyedInstance
  File "/var/lib/jenkins/jobs/Balrog/workspace/vendor/lib/python/migrate/versioning/util/__init__.py", line 81, in <module>
    @decorator
TypeError: 'module' object is not callable

Comment 1

[[e-mail] (:bhearsum)]

Attachment: add PYTHONDONTWRITEBYTECODE to prevent this from happening again

Hm. It looks like I hit this locally too. The subsequent revision works fine, so I'm betting this is a case of .pyc files on the Jenkins server. This patch will make sure we never write them again. I think I can get Jenkins to clobber the existing directory.

Comment 2

[[e-mail] (:bhearsum)]

The one-off clean-up of the workspace on Jenkins that I did fixed the acute issue.
This patch should fix it chronically.