812556 - With two events in conflict with the same event, but that do not conflict with each other - stack the events, don't have one event overlay all events (readability)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P3)

Description

[Jason Smith [:jsmith]]

Build:

Device - Unagi

Hashes

  <project name="gaia" path="gaia" remote="b2g" revision="620399e19efe849b9dddeffe7e11003847f6b268"/>
  <project name="releases-mozilla-aurora" path="gecko" remote="mozilla" revision="f423bd0551fcf872eb58064ed72ed2a4aed2c2d2"/>

Steps:

1. Create an event that spans an hour (let's say 11am - 12pm)
2. Create an event that spans a part of that event's time from #1 (let's say 11am - 11:15am)
3. Create an event that spans a different part that event's time from #1 (let's say 11:15am - 11:30am)
4. View the events in the month, week, day views

Expected:

The events should be able to be viewed in a three-way conflict and not overlap each other.

Actual:

One of the smaller events overpowers all of the other events, making it possible to only view one event. This is a regression - I know this wasn't happening before.

Comment 1

[Jason Smith [:jsmith]]

Change one piece I said above - the third event isn't even viewable in the week view. I know this was working before.

Comment 2

[Jason Smith [:jsmith]]

Attachment: 3 Way Conflict Day View

Comment 3

[Jason Smith [:jsmith]]

Attachment: 3 Way Conflict Week View

Comment 4

[Jason Smith [:jsmith]]

Attachment: 3 Way Conflict Month View

Comment 5

[Jason Smith [:jsmith]]

This appears to be a general problem that might be deriving from when we choose to show conflicts by layering events on top of one another - another random case of 2 events fails as well with 11am - 12:30pm and 11:15am - 12:15pm.

Comment 6

[Jason Smith [:jsmith]]

Opps - reseted assignee by accident.

Comment 7

[Jason Smith [:jsmith]]

It's possible also that the week view issue could be a separate bug. Let me know if that's the case.

Comment 8

[Les Orchard [:lorchard]]

Trying to understand what the desired layout looks like.

Current logic distinguishes between "conflict" (ie. events with start time within 5 min of each other) and "overlap" (ie. time span coincides with other events in general), and that looks like what's going on here.

"Conflicts" event bars get laid out side-by-side. But, "overlap" events get slightly indented and overlay other events.

So, as described here, there are 2 conflicts (11am-12:30pm & 11:00am-11:15am) and 1 overlap (11:15am-11:30)

Comment 9

[Les Orchard [:lorchard]]

(In reply to Jason Smith [:jsmith] from comment #7)
> It's possible also that the week view issue could be a separate bug. Let me
> know if that's the case.

Yeah, I think the week view is separate from this. Looks like there's not an overlap - the event is missing entirely

Comment 10

[Jason Smith [:jsmith]]

Comment on attachment 682535 [details]
3 Way Conflict Week View

Week view is a separate issue. Filing a different bug.

Comment 11

[Jason Smith [:jsmith]]

bug 812567 filed for the week view issue.

Comment 12

[Casey Yee]

Hi there,
This is how it should should appear:
https://www.dropbox.com/s/cy1dz3145f8qf57/Calendar-DayView-3wayConflict-11-16-12.jpg

Comment 13

[Jason Smith [:jsmith]]

(In reply to Casey Yee [:cyee] from comment #12)
> Hi there,
> This is how it should should appear:
> https://www.dropbox.com/s/cy1dz3145f8qf57/Calendar-DayView-3wayConflict-11-
> 16-12.jpg

Ah. Well, apparently we aren't doing that right now then.

Comment 14

[Jason Smith [:jsmith]]

After digging into this, knowing that this functionally correct, but is a bit of a weird rendering issue, I'm removing the basecamp nom - probably wouldn't block on this, even though I want it.

Comment 15

[Les Orchard [:lorchard]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6562

Pointer to Github pull-request

Comment 16

[Mila Davydova]

Unagi, build ID:20130113070202
I was able to reproduce this issue only when 2 of not conflicting with each other events span for 15 minutes each (in the same 30 minutes period), and conflicting with the 3rd event - as it is specified in steps.

I have created a separate bug https://bugzilla.mozilla.org/show_bug.cgi?id=830180 for this issue. 

In the situation when 2 of not conflicting with each other events span 30 min and conflicting with the 3rd event, all the events are displaying correctly