Closed
Bug 812558
Opened 12 years ago
Closed 12 years ago
Warning about clobber-needed when cancelling non-Try builds is not shown for B2G
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
(Whiteboard: [sheriff-want])
Attachments
(1 file)
6.21 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
{ var clobberNeeded = (result.machine.type == 'Build' && !UserInterface.treeInfo.isTry); if (clobberNeeded && !confirm("Interrupting non-clobber builds is unsafe. If you stop this build you must request a clobber (bug 658934). Interrupt the build anyway?")) return; } So anything that doesn't use the pretty-name "Build", won't get the warning (excl Nightly, since that is always clobber, so intentional): { /b2g.*gecko(?:-debug)? build/i.test(name) ? "B2G Gecko Build" : /b2g.*(?:panda|unagi)_dep/i.test(name) ? "B2G Device Image Build" : /spidermonkey.*-dtrace/i.test(name) ? "SpiderMonkey DTrace" : /spidermonkey.*-rootanalysis/i.test(name) ? "SpiderMonkey --enable-root-analysis" : /spidermonkey.*-warnaserr/i.test(name) ? "SpiderMonkey --enable-sm-fail-on-warnings" : /dxr/i.test(name) ? "DXR Index Build" : ... /build/i.test(name) ? "Build" : ... /valgrind/i.test(name) ? "Valgrind" : } We should probably just: 1) Append "Build" to any of the above that are in fact builds, and don't already include it. 2) Substring search for "Build" rather than |result.machine.type == 'Build'|
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Armen, can you confirm whether or not Valgrind and/or Spidermonkey are always clobber? (I would tend to think they are not)
Attachment #682581 -
Flags: review?(mbrubeck)
Attachment #682581 -
Flags: feedback?(armenzg.bugzilla)
Comment 2•12 years ago
|
||
Comment on attachment 682581 [details] [diff] [review] Patch v1 Looks okay to me.
Attachment #682581 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Landed so we can pick this up with the next push to prod: https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/b3bcaa43615a Armen, please can confirm comment 1 at some point, just so I know we don't need to make further adjustments :-)
Assignee | ||
Comment 4•12 years ago
|
||
In production.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•12 years ago
|
||
Armen, ping?
Assignee | ||
Updated•11 years ago
|
Attachment #682581 -
Flags: feedback?(armenzg.bugzilla)
Updated•10 years ago
|
Product: Webtools → Tree Management
Updated•9 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•