81278 - Using configure flag --with-jpeg=no

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[MichaelWright9]

Built with the flag --with-jpeg=no so that the system JPEG shared library 
would not be used (mozilla 0.9). This means the imgjpeg library uses the mozjpeg 
library. The mozjpeg library should be made as a static library not shared.

Comment 1

[MichaelWright9]

I think the --with-jpeg=no flag should work like the --with-png=no flag. When 
the --with-png=no flag is used, mozilla builds/links with the static library 
libmozpng.a.

Comment 2

[Stuart Parmenter]

over to build

Comment 3

[cls]

For the most part, I wouldn't care except it looks like we link jpeg against 3
different libs which means symbol duplication.  Png is really only used in one
place (either libimg's pngcom or libpr0n's png decoder).

Comment 4

[TVL]

Aren't the other uses in the older image decoders (or have i got my module names 
confused again)?  So are they an issue?

You can avoid some the symbol duplication by using the configure option to roll a 
few components into one when using the static lib option.  Or do we need to 
support using the non system version as both shared and static?

Comment 5

[cls]

jpeg is linked twice in both libimg & libpr0n (and once in xpfe/bootstrap for
static builds).  Once in the jpeg decoder and once in the mng decoder. With the
static build landing, we inadvertently made jpeg build static always so I'll
just leave it and close this out.

Comment 6

[hacker formerly known as [e-mail]]

*** Bug 114679 has been marked as a duplicate of this bug. ***

Comment 7

[hacker formerly known as [e-mail]]

Tor's reopening this issue since mng is being reintroduced into the build RSN.

Comment 8

[hacker formerly known as [e-mail]]

Marking fixed again.  If anyone really thinks that the 120k (yes, I measured it)
is worth arguing about at this point in the game, feel free to reopen.