812845 - add more spelling text attribute tests

Status: NEW

(Core :: Disability Access APIs, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 682835 [details] [diff] [review]
patch

Review of attachment 682835 [details] [diff] [review]:
-----------------------------------------------------------------

as I understand it's follow up from bug 770564. Should you add a reference to that bug in mochitest?

nice, r=me

::: accessible/tests/mochitest/events/test_textattrchange.html
@@ +28,5 @@
>        Components.interfaces.nsIDOMNSEditableElement;
>  
>      Components.utils.import("resource://gre/modules/InlineSpellChecker.jsm");
>  
> +    function spelledTextInvoker(aID, aText,  aTests)

nit: two spaces before aTests

@@ +111,5 @@
> +      tests = [
> +        { misspelled: true, start: 0, end: 4},
> +        { misspelled: false, start: 4, end: 8}
> +      ];
> +      gQueue.push(new spelledTextInvoker("input", "taht cat", tests));

nit: line after

Comment 3

[Trevor Saunders (:tbsaunde)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/1b6d5e373bcc

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/4a5a32f5c5b8 - as frequently as we were hitting timeouts like https://tbpl.mozilla.org/php/getParsedLog.php?id=17194619&tree=Mozilla-Inbound (Win7, WinXP, Linux64, so far), you shouldn't need to retrigger the tests on your try push with logging more than three times to catch it.

Comment 5

[Trevor Saunders (:tbsaunde)]

(In reply to Phil Ringnalda (:philor) from comment #4)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/4a5a32f5c5b8 - as
> frequently as we were hitting timeouts like
> https://tbpl.mozilla.org/php/getParsedLog.php?id=17194619&tree=Mozilla-
> Inbound (Win7, WinXP, Linux64, so far), you shouldn't need to retrigger the
> tests on your try push with logging more than three times to catch it.

https://tbpl.mozilla.org/?tree=Try&rev=4caa7f56fe7d seems to disagree :(

Comment 6

[alexander :surkov (:asurkov)]

Trev, enable logging and reland it I think. We need to figure out where the bug is.

Comment 7

[Trevor Saunders (:tbsaunde)]

ok, here goes
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/44dfb958ad81
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ba13ced37c0e

Comment 8

[Trevor Saunders (:tbsaunde)]

failed again in https://tbpl.mozilla.org/php/getParsedLog.php?id=17699892&tree=Mozilla-Inbound

Comment 9

[Trevor Saunders (:tbsaunde)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/9907e4cc5d91

Comment 10

[alexander :surkov (:asurkov)]

instead of putting and backing out it can you just comment/uncomment related code? It must be more friendly to hg history.

Comment 11

[alexander :surkov (:asurkov)]

it's not enough info, you need to extend system logging capabilities:

registered: event type: text attribute changed, target: [ 'input@id="input" node', address: [object HTMLInputElement] ]

Event queue:
  invoke: text attribute change for misspelled text
5475 INFO TEST-INFO | chrome://mochitests/content/a11y/accessible/events/test_textattrchange.html | Invoke the 'text attribute change for misspelled text' test { expected 'text attribute changed' event;  }

Event type: state change. Target: ['toolbarbutton@id="urlbar-reload-button" node', address: [object XULElement], role: pushbutton, name: 'Location', address: [xpconnect wrapped nsIAccessible]]

Event type: state change. Target: ['toolbarbutton@id="urlbar-reload-button" node', address: [object XULElement], role: pushbutton, name: 'Location', address: [xpconnect wrapped nsIAccessible]]

Event type: hide. Target: ['null node', address: [object Text], role: text leaf, name: 'valid text inalid tixt', address: [xpconnect wrapped nsIAccessible]]

Event type: text removed, start: 0, length: 22, removed text: valid text inalid tixt. Target: ['input@id="input" node', address: [object HTMLInputElement], role: entry, address: [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleText)]]

Event type: value change. Target: ['input@id="input" node', address: [object HTMLInputElement], role: entry, address: [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleText)]]

Event type: show. Target: ['null node', address: [object Text], role: text leaf, name: 'that', address: [xpconnect wrapped nsIAccessible]]

Event type: text inserted, start: 0, length: 4, inserted text: that. Target: ['input@id="input" node', address: [object HTMLInputElement], role: entry, address: [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleText)]]

Event type: reorder. Target: ['input@id="input" node', address: [object HTMLInputElement], role: entry, address: [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleText)]]

Event type: text caret moved. Target: ['input@id="input" node', address: [object HTMLInputElement], role: entry, address: [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessibleText)]]
5476 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/events/test_textattrchange.html | Test timed out.
args: ['/home/cltbld/talos-slave/test/build/bin/screentopng']