Last Comment Bug 813019 - get rid of AccMutationEvent::mNode
: get rid of AccMutationEvent::mNode
Status: RESOLVED FIXED
[good first bug][mentor=surkov.alexan...
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla20
Assigned To: Catalin Iordache
:
Mentors:
Depends on:
Blocks: cleana11y 819664
  Show dependency treegraph
 
Reported: 2012-11-19 02:34 PST by alexander :surkov
Modified: 2013-08-04 11:54 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
replaces (849 bytes, text/plain)
2012-12-15 07:25 PST, Catalin Iordache
no flags Details
bug-813019 (1.74 KB, patch)
2012-12-18 18:43 PST, Catalin Iordache
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-11-19 02:34:32 PST
spun off bug 678454 comment #12:

Replace document->GetContainerAccessible(aEvent->mNode); on aEvent->mAccessible->Parent(). We can do that because CreateTextChangeEventFor is called before we mutate the tree.
Comment 1 Catalin Iordache 2012-12-14 13:17:13 PST
Hi. I'm new here and I would like to work at this bug.
Comment 2 Catalin Iordache 2012-12-14 13:20:05 PST
In which file I have to look for the  GetContainerAccessible ?
Comment 3 alexander :surkov 2012-12-15 05:26:29 PST
(In reply to Catalin Iordache from comment #2)
> In which file I have to look for the  GetContainerAccessible ?

you could use mxr tool to search things (for example, http://mxr.mozilla.org/mozilla-central/search?string=document-%3EGetContainerAccessible%28aEvent-%3EmNode%29;)

thank you for taking it.
Comment 4 Catalin Iordache 2012-12-15 07:25:12 PST
Created attachment 692596 [details]
replaces

Replace document->GetContainerAccessible(aEvent->mNode) with : aEvent->mAccessible->Parent()
Comment 5 alexander :surkov 2012-12-15 08:35:34 PST
Catalin, you need to ask someone for review when you upload the patch (here you will find a list of peers for each component - https://wiki.mozilla.org/Modules/All). In this case I'd recommend Trevor for review.
Comment 6 Trevor Saunders (:tbsaunde) 2012-12-16 23:42:24 PST
Comment on attachment 692596 [details]
replaces

> NotificationController::CreateTextChangeEventFor(AccMutationEvent* aEvent)
> {
>   DocAccessible* document = aEvent->GetDocAccessible();
>-  Accessible* container = document->GetContainerAccessible(aEvent->mNode);
>+  Accessible* container = aEvent->mAccessible->Parent();

you should remove the member from AccMutationEvent class as well.
Comment 7 Catalin Iordache 2012-12-18 09:30:12 PST
i can't find AccMutationEvent class. Any hints?
Comment 8 Trevor Saunders (:tbsaunde) 2012-12-18 09:34:36 PST
(In reply to Catalin Iordache from comment #7)
> i can't find AccMutationEvent class. Any hints?

accessible/src/base/AccEvent.h
Comment 9 Catalin Iordache 2012-12-18 18:43:59 PST
Created attachment 693718 [details] [diff] [review]
bug-813019

mNode from AccEvent.h removed
Comment 10 Trevor Saunders (:tbsaunde) 2012-12-19 14:00:08 PST
you should use [checkin-needed] white board field not checkin? flag.
Comment 11 Ryan VanderMeulen [:RyanVM] 2012-12-19 17:09:10 PST
Actually, the checkin-needed keyword is what you really want :)
Comment 12 Ryan VanderMeulen [:RyanVM] 2012-12-19 17:32:21 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dcf9f0a42d8
Comment 13 Catalin Iordache 2012-12-19 17:57:31 PST
sorry for my mistakes, next time I'll know what to do.
Comment 14 Ed Morley [:emorley] 2012-12-20 13:45:01 PST
https://hg.mozilla.org/mozilla-central/rev/3dcf9f0a42d8

Note You need to log in before you can comment on or make changes to this bug.