get rid of AccMutationEvent::mNode

RESOLVED FIXED in mozilla20

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: surkov, Assigned: Catalin Iordache)

Tracking

(Blocks: 1 bug)

unspecified
mozilla20
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 attachment, 1 obsolete attachment)

1.74 KB, patch
tbsaunde
: review+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
spun off bug 678454 comment #12:

Replace document->GetContainerAccessible(aEvent->mNode); on aEvent->mAccessible->Parent(). We can do that because CreateTextChangeEventFor is called before we mutate the tree.
(Assignee)

Comment 1

5 years ago
Hi. I'm new here and I would like to work at this bug.
(Assignee)

Comment 2

5 years ago
In which file I have to look for the  GetContainerAccessible ?
(Reporter)

Comment 3

5 years ago
(In reply to Catalin Iordache from comment #2)
> In which file I have to look for the  GetContainerAccessible ?

you could use mxr tool to search things (for example, http://mxr.mozilla.org/mozilla-central/search?string=document-%3EGetContainerAccessible%28aEvent-%3EmNode%29;)

thank you for taking it.
Assignee: nobody → catalinn.iordache
(Assignee)

Comment 4

5 years ago
Created attachment 692596 [details]
replaces

Replace document->GetContainerAccessible(aEvent->mNode) with : aEvent->mAccessible->Parent()
Attachment #692596 - Flags: review?
(Reporter)

Comment 5

5 years ago
Catalin, you need to ask someone for review when you upload the patch (here you will find a list of peers for each component - https://wiki.mozilla.org/Modules/All). In this case I'd recommend Trevor for review.
(Assignee)

Updated

5 years ago
Attachment #692596 - Flags: review? → review?(trev.saunders)
Comment on attachment 692596 [details]
replaces

> NotificationController::CreateTextChangeEventFor(AccMutationEvent* aEvent)
> {
>   DocAccessible* document = aEvent->GetDocAccessible();
>-  Accessible* container = document->GetContainerAccessible(aEvent->mNode);
>+  Accessible* container = aEvent->mAccessible->Parent();

you should remove the member from AccMutationEvent class as well.
Attachment #692596 - Flags: review?(trev.saunders)
(Assignee)

Comment 7

5 years ago
i can't find AccMutationEvent class. Any hints?
(In reply to Catalin Iordache from comment #7)
> i can't find AccMutationEvent class. Any hints?

accessible/src/base/AccEvent.h
(Assignee)

Comment 9

5 years ago
Created attachment 693718 [details] [diff] [review]
bug-813019

mNode from AccEvent.h removed
Attachment #692596 - Attachment is obsolete: true
Attachment #693718 - Flags: review?(trev.saunders)
Attachment #693718 - Flags: review?(trev.saunders) → review+
(Assignee)

Updated

5 years ago
Attachment #693718 - Flags: checkin?
Attachment #693718 - Flags: checkin?
you should use [checkin-needed] white board field not checkin? flag.
Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++] → [checkin-needed][good first bug][mentor=surkov.alexander@gmail.com][lang=c++]
Actually, the checkin-needed keyword is what you really want :)
Keywords: checkin-needed
Whiteboard: [checkin-needed][good first bug][mentor=surkov.alexander@gmail.com][lang=c++] → [good first bug][mentor=surkov.alexander@gmail.com][lang=c++]
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dcf9f0a42d8
Keywords: checkin-needed
(Assignee)

Comment 13

5 years ago
sorry for my mistakes, next time I'll know what to do.
https://hg.mozilla.org/mozilla-central/rev/3dcf9f0a42d8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Blocks: 819664
You need to log in before you can comment on or make changes to this bug.