813022 - Mozharness make failures should be reported as ERRORs not INFO

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Ed Morley [:emorley]]

eg:
{
02:31:24     INFO -  make: *** [out/target/product/panda/obj/lib/libdl.so] Error 1
02:31:24     INFO -  make: *** Deleting file `out/target/product/panda/obj/lib/libdl.so'
02:31:24     INFO -  make: *** Waiting for unfinished jobs....
02:31:24     INFO -  make: *** [out/target/product/panda/obj/lib/libz.so] Error 1
02:31:24     INFO -  make: *** Deleting file `out/target/product/panda/obj/lib/libz.so'
02:31:24     INFO -  target Strip: libexpat (out/target/product/panda/obj/lib/libexpat.so)
02:31:24     INFO -  prebuilt/linux-x86/toolchain/arm-linux-androideabi-4.4.x/bin/arm-linux-androideabi-objcopy:out/target/product/panda/obj/lib/stVjpH2s: cannot create debug link section `out/target/product/panda/symbols/system/lib/libstlport.so': Invalid operation
02:31:24     INFO -  make: *** [out/target/product/panda/obj/lib/libstlport.so] Error 1
02:31:24     INFO -  make: *** Deleting file `out/target/product/panda/obj/lib/libstlport.so'
02:31:24     INFO -  prebuilt/linux-x86/toolchain/arm-linux-androideabi-4.4.x/bin/arm-linux-androideabi-objcopy:out/target/product/panda/obj/lib/stxBKoRt: cannot create debug link section `out/target/product/panda/symbols/system/lib/libexpat.so': Invalid operation
02:31:24     INFO -  make: *** [out/target/product/panda/obj/lib/libexpat.so] Error 1
02:31:24     INFO -  make: *** Deleting file `out/target/product/panda/obj/lib/libexpat.so'
}

All we got in TBPL's annotated summary was:
{
02:31:24    ERROR - Return code: 2
02:31:25    FATAL - failed to build
02:31:25    FATAL - Exiting 2
}

Comment 1

[Aki Sasaki (not active)]

This is a specific reason why we want context lines.
I'm not sure what more we can do til we have them, except add specific error list lines.

We can leave as fixed-with-688338 or dup it.

Comment 2

[Ed Morley [:emorley]]

(In reply to Aki Sasaki [:aki] from comment #1)
> This is a specific reason why we want context lines.
> I'm not sure what more we can do til we have them, except add specific error
> list lines.

Could we add something like the equivalent of TBPL's:
"make(?:\[\d+\])?: \*\*\*/"

Comment 3

[Aki Sasaki (not active)]

We can. I would bet this will be highlight way more than we want, but it's worth a shot.

Comment 4

[Aki Sasaki (not active)]

Attachment: add edmorley's regex to MakefileErrorList

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 739856 [details] [diff] [review]
add edmorley's regex to MakefileErrorList

https://hg.mozilla.org/build/mozharness/rev/35d351b30c9b

Comment 6

[Aki Sasaki (not active)]

Merged to production.