Mozharness make failures should be reported as ERRORs not INFO

RESOLVED FIXED

Status

Release Engineering
Applications: MozharnessCore
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: emorley, Assigned: aki)

Tracking

(Blocks: 1 bug, {sheriffing-P1})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozharness])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
eg:
{
02:31:24     INFO -  make: *** [out/target/product/panda/obj/lib/libdl.so] Error 1
02:31:24     INFO -  make: *** Deleting file `out/target/product/panda/obj/lib/libdl.so'
02:31:24     INFO -  make: *** Waiting for unfinished jobs....
02:31:24     INFO -  make: *** [out/target/product/panda/obj/lib/libz.so] Error 1
02:31:24     INFO -  make: *** Deleting file `out/target/product/panda/obj/lib/libz.so'
02:31:24     INFO -  target Strip: libexpat (out/target/product/panda/obj/lib/libexpat.so)
02:31:24     INFO -  prebuilt/linux-x86/toolchain/arm-linux-androideabi-4.4.x/bin/arm-linux-androideabi-objcopy:out/target/product/panda/obj/lib/stVjpH2s: cannot create debug link section `out/target/product/panda/symbols/system/lib/libstlport.so': Invalid operation
02:31:24     INFO -  make: *** [out/target/product/panda/obj/lib/libstlport.so] Error 1
02:31:24     INFO -  make: *** Deleting file `out/target/product/panda/obj/lib/libstlport.so'
02:31:24     INFO -  prebuilt/linux-x86/toolchain/arm-linux-androideabi-4.4.x/bin/arm-linux-androideabi-objcopy:out/target/product/panda/obj/lib/stxBKoRt: cannot create debug link section `out/target/product/panda/symbols/system/lib/libexpat.so': Invalid operation
02:31:24     INFO -  make: *** [out/target/product/panda/obj/lib/libexpat.so] Error 1
02:31:24     INFO -  make: *** Deleting file `out/target/product/panda/obj/lib/libexpat.so'
}

All we got in TBPL's annotated summary was:
{
02:31:24    ERROR - Return code: 2
02:31:25    FATAL - failed to build
02:31:25    FATAL - Exiting 2
}
(Reporter)

Updated

6 years ago
Whiteboard: [mozharness][sheriff-want]
(Assignee)

Comment 1

6 years ago
This is a specific reason why we want context lines.
I'm not sure what more we can do til we have them, except add specific error list lines.

We can leave as fixed-with-688338 or dup it.
(Reporter)

Comment 2

6 years ago
(In reply to Aki Sasaki [:aki] from comment #1)
> This is a specific reason why we want context lines.
> I'm not sure what more we can do til we have them, except add specific error
> list lines.

Could we add something like the equivalent of TBPL's:
"make(?:\[\d+\])?: \*\*\*/"
(Assignee)

Comment 3

6 years ago
We can. I would bet this will be highlight way more than we want, but it's worth a shot.
(Reporter)

Updated

6 years ago
Keywords: sheriffing-P1
Whiteboard: [mozharness][sheriff-want] → [mozharness]
(Assignee)

Updated

5 years ago
Assignee: nobody → aki
(Assignee)

Comment 4

5 years ago
Created attachment 739856 [details] [diff] [review]
add edmorley's regex to MakefileErrorList
Attachment #739856 - Flags: review?(emorley)
(Reporter)

Updated

5 years ago
Attachment #739856 - Flags: review?(emorley) → review+
(Assignee)

Comment 5

5 years ago
Comment on attachment 739856 [details] [diff] [review]
add edmorley's regex to MakefileErrorList

https://hg.mozilla.org/build/mozharness/rev/35d351b30c9b
Attachment #739856 - Flags: checked-in+
(Assignee)

Comment 6

5 years ago
Merged to production.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering

Updated

4 years ago
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.