813039 - TBPL should recognise mock's "command timed out: NNNN seconds without output

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

TBPL currently only recognises "buildbot.slave.commands.TimeoutError".

This is fine for buildbot timeouts, due to:
https://hg.mozilla.org/build/buildbotcustom/file/tip/steps/unittest.py#l373

However, for mock timeouts we only get "command timed out: NNNN seconds without output".

As such, TBPL should match against "command timed out: NNNN seconds without output" instead, which should cover both cases.

We can then just cleanup https://hg.mozilla.org/build/buildbotcustom/file/tip/steps/unittest.py#l373 in bug 793782.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 683067 [details] [diff] [review]
Patch v1

Well, let's hope we done have normal and expected "command timed out"s.

Comment 3

[Ed Morley [:emorley]]

I couldn't see anything else when testing locally; but suspect the only way we're going to find out is by landing it :-)

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/8407ba67e1fa

Comment 4

[Ed Morley [:emorley]]

In production.