81307 - Get all new messages in current folder

Status: NEW

(MailNews Core :: Backend, enhancement)

Description

[Alec Flett]

an offshoot of bug 81303 - right now, from File->Offline, you can say "Get
Flagged messages" or "Get Selected messages" - but really the most useful thing
would be "Download New Messages" - it would automatically download all new
messages in the current folder... 

that way you don't have to go manually select all new messages, then do "Get
Selected Messages"

Comment 1

[David :Bienvenu]

Future...I agree this would be useful, but I don't think I have time to add new
features at this time. Please note that for the INBOX, at least, you can set a
hidden pref to make it download new msg bodies on every "get new mail". It's a
per-server pref "download_bodies_on_get_new_mail" but it's an "always on"
setting, not a command.

Comment 2

[Alec Flett]

Attachment: JS/XUL side of things

Comment 3

[Alec Flett]

Attachment: C++ side of things

Comment 4

[Alec Flett]

wanted this so bad, I coded it myself :)
turned out to be really easy.

I just added it to the offline menu.. this really makes life easier as an avid
offline user.

Comment 5

[David :Bienvenu]

Alec, if I read this correctly, this isn't going to work if the message is not
in the view. There's a better way of doing this, actually, without using the
view. You don't want to use the view, in fact.

Comment 6

[David :Bienvenu]

I know you just basically imitated the code for the flagged messages, but the
difference is that the flagged messages are most likely in the view because you
had to see them to flag them. Admittedly, that's not always true, but it usually
is. New messages very possibly not in view if you're in threaded mode.

Comment 7

[Alec Flett]

oh! Seems like a bug with flagged messages as well then :)

I'll look into not going through the view, but thanks for the feedback...

Comment 8

[David :Bienvenu]

right, it's a bug with flagged messages too, but not one you'd be likely to hit
as described above.

So, there are few ways to do this. The best way is probably NOT to iterate over
all the headers in the db looking for new ones, but to ask the db directly for
the "new set" (currently not a public interface, but available internally).
Then, just fetch the message bodies for ids in the new set. Now, you need to
convert the new set into a list of new msg ids (the new set is the same data
structure used to keep track of read news messages). The most direct way of
doing this would be to generate imap ranges from the new set ranges, though I'm
not sure there's code that does that. The alternative is to convert the new set
into individual imap uids, and then have the imap code turn that back into
ranges. I'm a little busy with .9.1 issues at the moment, but I can look into
this a little more during the quiet period.

Comment 9

[David :Bienvenu]

accepting, marking RFE

Comment 10

[[not reading bugmail]]

should we worry about changing severity to enhancement when changing bugs to RFE?

Comment 11

[David :Bienvenu]

->enh

Comment 12

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 13

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 14

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 15

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 16

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 17

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 18

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 19

[Robert Kaiser]

Comment on attachment 35001 [details] [diff] [review]
JS/XUL side of things

Karsten, there are lonely old patches here, could you take a look at them?

Comment 20

[Karsten Düsterloh]

See David's comments #5, #6 and #8.