Closed Bug 813097 Opened 12 years ago Closed 12 years ago

Evme - Shortcuts removal mode searchbar

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evyatar, Assigned: evyatar)

Details

Attachments

(1 file)

Fade out the searchbar and make it inactive during removal mode
3.87 KB, patch
crdlc
: review+
vingtetun
: approval-gaia-v1+
Details | Diff | Splinter Review 
When entering "remove mode" in shortcuts (Tap and Hold a shortcut)- the Searchbar is still active, and focusing on it breaks the UI.
Assignee: nobody → evyatar
How can I enter in "remove mode"
Tap and Hold a shortcut icon- the view should change, and all shortcuts should have X icons on top of them.
Comment on attachment 683103 [details] [diff] [review]
Fade out the searchbar and make it inactive during removal mode

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):
Attachment #683103 - Flags: review?(crdlc)
Attachment #683103 - Flags: review+
Attachment #683103 - Flags: approval-gaia-master?(21)
Component: Gaia → Gaia::Homescreen
Comment on attachment 683103 [details] [diff] [review]
Fade out the searchbar and make it inactive during removal mode

Review of attachment 683103 [details] [diff] [review]:
-----------------------------------------------------------------

Late feature work.
Attachment #683103 - Flags: approval-gaia-master?(21) → approval-gaia-master+
https://github.com/mozilla-b2g/gaia/commit/43e0fb8d372e4889f8d2b04d45d4137de3018925
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: