813231 - [email] viewing attached image fails because of new security constraint on mozActivity creation

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[Andrew Sutherland [:asuth] (he/him)]

A change to platform has broken viewing downloaded image attachments.

Like bug 812973 for camera, we need to make sure that we have our blobs available by the time a click event happens so that we can immediately instantiate the mozActivity without deferring anything to a future event.

The simplest solution is probably to move the device storage logic in MessageReaderCard.onViewAttachmentClick into a helper method that fetches the blob and sets the 'state' to 'downloaded' for the given node so that there's no race where the user can click on the button before we can display the attachment.  It would get called in both places we currently set 'downloaded' on the attachment; we would initially set the state to 'nodownload' while we are waiting for that function to run in buildBodyDom.

Comment 1

[Steve Chung [:steveck]]

Attachment: Patch for mozActivity new security constraint

Comment 2

[Nick Davidson]

Issue resolved - verified on Unagi build 20121231070201