[email] viewing attached image fails because of new security constraint on mozActivity creation

VERIFIED FIXED

Status

Firefox OS
Gaia::E-Mail
P2
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: asuth, Assigned: steveck)

Tracking

unspecified
x86_64
Linux

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
A change to platform has broken viewing downloaded image attachments.

Like bug 812973 for camera, we need to make sure that we have our blobs available by the time a click event happens so that we can immediately instantiate the mozActivity without deferring anything to a future event.

The simplest solution is probably to move the device storage logic in MessageReaderCard.onViewAttachmentClick into a helper method that fetches the blob and sets the 'state' to 'downloaded' for the given node so that there's no race where the user can click on the button before we can display the attachment.  It would get called in both places we currently set 'downloaded' on the attachment; we would initially set the state to 'nodownload' while we are waiting for that function to run in buildBodyDom.
(Assignee)

Updated

5 years ago
Assignee: nobody → schung
(Assignee)

Comment 1

5 years ago
Created attachment 683503 [details]
Patch for mozActivity new security constraint
Attachment #683503 - Flags: review?(bugmail)
(Reporter)

Updated

5 years ago
Attachment #683503 - Flags: review?(bugmail) → review+
blocking-basecamp: ? → +
Priority: -- → P2
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 2

5 years ago
Issue resolved - verified on Unagi build 20121231070201
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.