813237 - [music] share activity does not work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P2)

Description

[David Flanagan [:djf]]

Because of the new security restrictions on activities (see bug #812973) the music app's share activity no longer works.  The MozActivity() constructor must be called directly from the user event handler, not from an async device storage callback, and this means that the blob for the song to be shared will have to be fetched before the user asks to share it.

I've spoken with Casey, and he says it would be okay to move the share activity from the current sublist view to the now playing view. This would mean that there is only one possible song that could be shared at a time, and it is easy to keep the blob available for the currently playing song.

One option would just to keep using the context menu event but do it on the album art. But Casey is considering actually adding a share icon to that view somewhere.

Comment 1

[David Flanagan [:djf]]

It turns out (see bug 813413) that launching activities from a longpress is broken. If we want to get the music share activity fixed quickly, it would be best to have an actual button on the now playing page rather than having to block while waiting for the long press bug to be fixed.

Note also that in this morning's gaia meeting, Dietrich had no idea how to share songs since longpress is not discoverable at all.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This needs information on the UX/UI side. the longpress bug will be resolved by bug 813277