813274 - Submit add-on for admin review to bypass validation

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Kris Maglione [:kmag]]

+++ This bug was initially created as a clone of Bug #776017 +++

Rather than starting a revert war on bug 776017, I'm filing a new bug to do what the summary actually said. We need a way for admins to submit add-ons when validation fails, or to automatically flag for admin review when validation times out for ordinary users.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

Here's how I think this should work:

1) An admin goes to the Status & Versions page of an add-on, like https://addons.mozilla.org/en-US/developers/addon/amazon-mini-shop/versions

2) Click on the Upload a New Version button.

3) After submitting the form, and if validation fails, some button or checkbox appears that allows the admin to override submission and keep the file even with the validation errors.

Comment 2

[Dan Stillman]

I recognize that most add-ons are unaffected by this issue, but we're really stuck here. Zotero is a featured add-on on AMO, including in rotation in the back-to-school section at the top of the front page, and is now broken in significant ways in the shipping version of Firefox due to our inability to submit a new version.

Comment 3

[Kris Maglione [:kmag]]

I have a patch for this. It adds a checkbox to the file upload dialog for admins to override validation failures. At the moment, it's pretty liberal, in that it allows us to override pretty much any validation error. I'm going to look a little deeper and see if there are any pre-validator checks that we might not want to be able to override (e.g., duplicate version numbers). Beyond that, I need to write tests and it should be good to go.

There's no push this week, so this won't be live until next Thursday at the earliest.

https://people.mozilla.com/~kmaglione/images/234d3557f8661a6f.png

Comment 4

[Kris Maglione [:kmag]]

Bumping to critical since this is preventing the upload of r2d2b2g.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/4eb681b

Thanks for working on this, Kris!

Comment 6

[krupa raj[:krupa]]

This does not work for errors like "Could not parse install.rdf" or "UUID doesn't match" which is a good thing. I was able to override a failed validation.