[uxbranch][Font] Increasing and Unifying the Font Sizes of the Browser

VERIFIED FIXED

Status

Firefox OS
Gaia::Browser
P2
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: patryk, Assigned: patryk)

Tracking

({polish})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: visual design, usability, uxbranch, landed in uxbranch UX-P2, qa-verified)

Attachments

(10 attachments)

(Assignee)

Description

5 years ago
Increasing font sizes to at least 6pt to 1.4rem
Removing "bold" or "600" weight reference
Unifying layout and type spacing
(Assignee)

Comment 1

5 years ago
Fixed in UX Branch with https://github.com/patrykdesign/gaia/commit/1a972b3659c18c8ab1bbe3dfd3c6a614fda24a35
Summary: [Font] Increasing and Unifying the Font Sizes of the Browser → [Font][fixedinux] Increasing and Unifying the Font Sizes of the Browser
Whiteboard: visual design, usability → visual design, usability, fixedinux
(Assignee)

Updated

5 years ago
Summary: [Font][fixedinux] Increasing and Unifying the Font Sizes of the Browser → [FixedinUX][Font]Increasing and Unifying the Font Sizes of the Browser
(Assignee)

Updated

5 years ago
Summary: [FixedinUX][Font]Increasing and Unifying the Font Sizes of the Browser → [FixedinUX][Font] Increasing and Unifying the Font Sizes of the Browser
(Assignee)

Updated

5 years ago
Depends on: 813560
(Assignee)

Updated

5 years ago
No longer depends on: 813560
(Assignee)

Updated

5 years ago
Summary: [FixedinUX][Font] Increasing and Unifying the Font Sizes of the Browser → [uxbranch][Font] Increasing and Unifying the Font Sizes of the Browser
Whiteboard: visual design, usability, fixedinux → visual design, usability, uxbranch

Updated

5 years ago
Component: Gaia → Gaia::Browser
Created attachment 684181 [details]
screenshot

Not sure if we have to worry about the licensing line?
If that is fine then this is verified...
Flags: needinfo?(padamczyk)
(Assignee)

Comment 4

5 years ago
I didn't change the fonts on that page, just in the app, but looks correct.
Flags: needinfo?(padamczyk)
(Assignee)

Comment 5

5 years ago
See screenshots of the change.
Waiting for Gordon to merge, the first change didn't go through.
https://github.com/gordonbrander/gaia/pull/18
(Assignee)

Comment 6

5 years ago
Created attachment 685198 [details]
changes 1
(Assignee)

Comment 7

5 years ago
Created attachment 685199 [details]
changes 2
(Assignee)

Comment 8

5 years ago
Created attachment 685200 [details]
changes 3
(Assignee)

Updated

5 years ago
QA Contact: nhirata.bugzilla
Whiteboard: visual design, usability, uxbranch → visual design, usability, uxbranch, landed in uxbranch
Landed in UX branch: https://github.com/gordonbrander/gaia/commit/681164a9849f44cb817248b2a98914718a35f7fb
I found bug 816243 that happens regardless of this commit.
Created attachment 686297 [details]
screenshot 1 comparison
Created attachment 686298 [details]
screenshot 2 comparison
I also found bug 816151 in the main branch.  I don't think it's related.

Changes also occur in the startscreen, crashscreen, crash menu, highlights in the awesome page, and browser settings.
Created attachment 686300 [details]
screenshot

Not sure if it has to do with the changes here, kill the browser with an adb shell kill -11 <pid of browser> shows the button that's hard to press because it is hidden underneath the browser menu bar.
(Assignee)

Comment 15

5 years ago
Created attachment 686546 [details]
Top Sites - What I see
Created attachment 686605 [details]
screenshot from main branch

separate bugs were filed for the issue mentioned in comment 14 and the spacing issue.

https://bugzilla.mozilla.org/show_bug.cgi?id=816481
https://bugzilla.mozilla.org/show_bug.cgi?id=816482

The changes in this bug are in.  The enlarging of the crash report text pushed the reload button down which caused bug 816482 to appear from what I can tell.  I could be mistaken.
(Assignee)

Comment 17

5 years ago
Created attachment 687151 [details]
my new change seems to have worked.
(Assignee)

Comment 18

5 years ago
https://github.com/gordonbrander/gaia/pull/37
Reverted previous merge that introduced bug https://github.com/gordonbrander/gaia/commit/004ba9121ca8baf497dbaf8849b3431b23c40a63

Tested new fix on device and merged into UX branch: https://github.com/gordonbrander/gaia/commit/8ad2997d66586b89f12b259bfe319fd5ae85fd17
(Assignee)

Updated

5 years ago
Whiteboard: visual design, usability, uxbranch, landed in uxbranch → visual design, usability, uxbranch, landed in uxbranch UX-P2
polish bug 819168 happens in the main branch as well.
Whiteboard: visual design, usability, uxbranch, landed in uxbranch UX-P2 → visual design, usability, uxbranch, landed in uxbranch UX-P2, qa-verified
Fixed in 96b796c6ff4d3d56f3fc7f04aa9cf8df6694613d <https://github.com/mozilla-b2g/gaia/commit/96b796c6ff4d3d56f3fc7f04aa9cf8df6694613d>
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 22

5 years ago
Reviewed and verified on "Unagi" device
Build ID:20130102070202
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.