Closed
Bug 813283
Opened 12 years ago
Closed 12 years ago
[WebActivities] activity menu doesn't appear in fullscreen mode
Categories
(Firefox OS Graveyard :: Gaia::System, defect, P1)
Tracking
(blocking-basecamp:+)
RESOLVED
FIXED
blocking-basecamp | + |
People
(Reporter: djf, Assigned: alive)
Details
Attachments
(1 file)
In the gallery app, photos are displayed in fullscreen mode. If I tap on the share icon, I don't see the share menu, but then if I tap on the gallery icon to go back to the list of thumbnails, I see it. So while I'm in fullscreen the menu is hidden, but when I leave it appears. This is not yet testable, because the share activity is also broken by bug 812975, but once I fix that, you'll be able to confirm this bug.
Reporter | ||
Comment 1•12 years ago
|
||
I wonder if this is just a z-index issue in the system app? cc'ing fabrice and some people who have touched apps/system/js/activities.js recently
blocking-basecamp: --- → ?
Assignee | ||
Comment 2•12 years ago
|
||
Yes, this is a pure z-index problem and the solution is easy IMO. Just to add one line in apps/system/style/zindex.css
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → alive
Assignee | ||
Comment 3•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/6518 A quick fix to promote list menu based UI to on top of fullscreen element.
Attachment #683447 -
Flags: review?
Comment 4•12 years ago
|
||
Comment on attachment 683447 [details]
PR 6518
Not sure who you are asking for review but r=me.
Attachment #683447 -
Flags: review? → review+
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #4) > Comment on attachment 683447 [details] > PR 6518 > > Not sure who you are asking for review but r=me. I encountered the Bugzilla Update when updating bugs :/ Must be something wrong but anyway thanks!
Reporter | ||
Comment 6•12 years ago
|
||
Triage team: let's get this marked blocking so we can land it. The Gallery app cannot share photos without this one-line fix!
Comment 7•12 years ago
|
||
P1 blocker based on comment 6. gallery app needs to share images.
blocking-basecamp: ? → +
Priority: -- → P1
Comment 8•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/cbcf88d6e512bbd6845babb56235dae398ca5050
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 9•12 years ago
|
||
Vivien beat me to landing this fix. I've tested this patch and it works for me. (You can't test it on gaia itself; it also requires the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=812975 in order to verify that it fixes the problem.
You need to log in
before you can comment on or make changes to this bug.
Description
•