Closed
Bug 813287
Opened 12 years ago
Closed 12 years ago
Use greprefs.js for health reports preferences
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
|
5.77 KB,
patch
|
glandium
:
review+
rnewman
:
review+
|
Details | Diff | Splinter Review |
According to bsmedberg and glandium, we were doing prefs wrong. For the model where we want a common set of prefs across all applications supplemented by per-app overrides, we need the core preferences to be in greprefs.js. This patch concatenates healthreport-prefs.js to greprefs.js. See also bug 813259 for the long-term solution. While I was here, I also added a B2G app override to bypass policy acceptance. glandium gets build config review. rnewman gets FHR aspect.
Attachment #683286 -
Flags: review?(rnewman)
Attachment #683286 -
Flags: review?(mh+mozilla)
|
||
Updated•12 years ago
|
Attachment #683286 -
Flags: review?(mh+mozilla) → review+
|
||
Comment 1•12 years ago
|
||
Comment on attachment 683286 [details] [diff] [review] Use greprefs.js for health report prefs storage Review of attachment 683286 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #683286 -
Flags: review?(rnewman) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/services/services-central/rev/eaeae002559b
Assignee: nobody → gps
Status: NEW → ASSIGNED
Whiteboard: [fixed in services]
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1bbcfe1c6608
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla20
|
||
Updated•11 years ago
|
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla20 → Firefox 20
|
||
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•