Closed Bug 813287 Opened 7 years ago Closed 7 years ago

Use greprefs.js for health reports preferences

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file)

According to bsmedberg and glandium, we were doing prefs wrong. For the model where we want a common set of prefs across all applications supplemented by per-app overrides, we need the core preferences to be in greprefs.js.

This patch concatenates healthreport-prefs.js to greprefs.js. See also bug 813259 for the long-term solution.

While I was here, I also added a B2G app override to bypass policy acceptance.

glandium gets build config review.
rnewman gets FHR aspect.
Attachment #683286 - Flags: review?(rnewman)
Attachment #683286 - Flags: review?(mh+mozilla)
Attachment #683286 - Flags: review?(mh+mozilla) → review+
Comment on attachment 683286 [details] [diff] [review]
Use greprefs.js for health report prefs storage

Review of attachment 683286 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #683286 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/services/services-central/rev/eaeae002559b
Assignee: nobody → gps
Status: NEW → ASSIGNED
Whiteboard: [fixed in services]
Blocks: 718066
https://hg.mozilla.org/mozilla-central/rev/1bbcfe1c6608
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla20
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla20 → Firefox 20
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.