Last Comment Bug 813299 - move the '#filter substitution' line in *.xul files below the <?xml?> header
: move the '#filter substitution' line in *.xul files below the <?xml?> header
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 20.0
Assigned To: :aceman
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-19 13:36 PST by :aceman
Modified: 2012-11-23 10:02 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (2.42 KB, patch)
2012-11-19 13:38 PST, :aceman
standard8: review+
Details | Diff | Splinter Review

Description :aceman 2012-11-19 13:36:40 PST
I found 2 occurrences in c-c:
mail/base/content/messageWindow.xul
mail/base/content/messenger.xul

From studying other source files it seems the "#filter substitution" line does not need to be on the first line of a file.

The <?xml?> header not being in the first line of the file causes my text editor not identify the file as XML and not applying proper syntax highlighting.

The fix seems to be a more correct way than just forcing the editor to treat all .xul files as xml.
Comment 1 :aceman 2012-11-19 13:38:02 PST
Created attachment 683295 [details] [diff] [review]
patch
Comment 2 Mark Banner (:standard8, afk until Dec) 2012-11-21 01:24:05 PST
Comment on attachment 683295 [details] [diff] [review]
patch

Looks fine
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-11-23 10:02:00 PST
https://hg.mozilla.org/comm-central/rev/b95c3dfb01e3

Note You need to log in before you can comment on or make changes to this bug.