move the '#filter substitution' line in *.xul files below the <?xml?> header

RESOLVED FIXED in Thunderbird 20.0

Status

Thunderbird
General
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 20.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I found 2 occurrences in c-c:
mail/base/content/messageWindow.xul
mail/base/content/messenger.xul

From studying other source files it seems the "#filter substitution" line does not need to be on the first line of a file.

The <?xml?> header not being in the first line of the file causes my text editor not identify the file as XML and not applying proper syntax highlighting.

The fix seems to be a more correct way than just forcing the editor to treat all .xul files as xml.
(Assignee)

Comment 1

5 years ago
Created attachment 683295 [details] [diff] [review]
patch
Attachment #683295 - Flags: review?(mbanner)
Comment on attachment 683295 [details] [diff] [review]
patch

Looks fine
Attachment #683295 - Flags: review?(mbanner) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/b95c3dfb01e3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
You need to log in before you can comment on or make changes to this bug.