Closed Bug 813311 Opened 8 years ago Closed 8 years ago

Make Axis.java non-public again

Categories

(Firefox for Android :: Toolbar, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Patch (obsolete) — Splinter Review
Still building this but it's fairly straightforward.
Attachment #683303 - Flags: review?(chrislord.net)
Comment on attachment 683303 [details] [diff] [review]
Patch

Review of attachment 683303 [details] [diff] [review]:
-----------------------------------------------------------------

I do tend to think that having such a specific method is a sign our abstraction isn't serving us as well as it should, but on the other hand, this is overall a code reduction and limits unnecessary exposure of internal classes, so I guess it's a good thing. LGTM.
Attachment #683303 - Flags: review?(chrislord.net) → review+
(In reply to Chris Lord [:cwiiis] from comment #2)
> I do tend to think that having such a specific method is a sign our
> abstraction isn't serving us as well as it should

... or we're using the wrong abstraction. What do you think of this instead? There's no reason the shadow needs to be bound to the concept of overscroll, really.
Attachment #683581 - Flags: review?(chrislord.net)
Comment on attachment 683581 [details] [diff] [review]
Alternative patch

Review of attachment 683581 [details] [diff] [review]:
-----------------------------------------------------------------

Much better. Why did we not think of this.
Attachment #683581 - Flags: review?(chrislord.net) → review+
Comment on attachment 683303 [details] [diff] [review]
Patch

Obsoleting the first patch I had because the second one is better.
Attachment #683303 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/fae73eb102d5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.