813311 - Make Axis.java non-public again

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Still building this but it's fairly straightforward.

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 683303 [details] [diff] [review]
Patch

Review of attachment 683303 [details] [diff] [review]:
-----------------------------------------------------------------

I do tend to think that having such a specific method is a sign our abstraction isn't serving us as well as it should, but on the other hand, this is overall a code reduction and limits unnecessary exposure of internal classes, so I guess it's a good thing. LGTM.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Alternative patch

(In reply to Chris Lord [:cwiiis] from comment #2)
> I do tend to think that having such a specific method is a sign our
> abstraction isn't serving us as well as it should

... or we're using the wrong abstraction. What do you think of this instead? There's no reason the shadow needs to be bound to the concept of overscroll, really.

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 683581 [details] [diff] [review]
Alternative patch

Review of attachment 683581 [details] [diff] [review]:
-----------------------------------------------------------------

Much better. Why did we not think of this.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 683303 [details] [diff] [review]
Patch

Obsoleting the first patch I had because the second one is better.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fae73eb102d5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fae73eb102d5