813337 - [Browser] Incorrect Error UI is being displayed

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Browser, defect, P3)

Description

[Peter La]

Attachment: Screenshot

See attached screenshot.

The folder with sad face icon is really rough, and probably a placeholder.

Also, what is that white line on the bottom right?

Comment 1

[Ben Francis [:benfrancis]]

As far as I know that was intended to be the final icon.

The "white line" at the bottom right is the top of the reload button. It looks like there's a CSS bug preventing it from being fully shown but I can't reproduce the problem. Do you have steps to reproduce? I'm guessing you were just browsing and the web page crashed right?

Comment 2

[Patryk Adamczyk [:patryk] UX]

This screen could benefit from another pass.

Comment 3

[Patryk Adamczyk [:patryk] UX]

Eric, please sync with Ian & Stephen to see what they are doing.

Comment 4

[Patryk Adamczyk [:patryk] UX]

Hey Ben, so I did some background research / refreshment.
So it appears that the current UI seen above is for crashed tabs. And ideally should happen rarely. The correct UI can seen here: https://www.dropbox.com/sh/u1rv1tr411clqu1/QytqobE2aQ 
The correct UI has buttons to reload the tab.

It would be a poor reflection of the product, if we apologized for errors not related to the performance / stability of our code, like a webpage not responding. Instead we should use the error screen found here:
https://www.dropbox.com/sh/57puqw6dr0dlus3/L6YX6IRTb3

Comment 5

[Patryk Adamczyk [:patryk] UX]

Attachment: Correct error ui

Comment 6

[Ben Francis [:benfrancis]]

Hi Patryk,

There's no incorrect implementation here. The crash screen is only displayed when the browser app receives a "fatal" mozbrowsererror event (the content process has crashed), and only when the browser app is in the foreground. A reload button is displayed and a close button is also displayed unless the current tab is the only open tab and therefore can not be closed. Peter's screenshot seems to show a CSS bug where these buttons are partially obscured but I haven't yet been able to reproduce this bug.

If the browser app is in the background when a fatal error is received it may be that the content process was killed due to low memory so the crash screen is not displayed, tabs are just reloaded when the user selects them.

Any other types of errors (the second link you posted) are handled by Gecko and may not have been implemented to spec yet, but that's not the responsibility of the browser app. There are separate bugs tracking that work.