Closed
Bug 813356
Opened 13 years ago
Closed 13 years ago
OS crash with this testcase, that's opening/closing windows
Categories
(Firefox OS Graveyard :: General, defect, P1)
Tracking
(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)
RESOLVED
FIXED
| blocking-basecamp | + |
People
(Reporter: martijn.martijn, Assigned: cjones)
References
()
Details
(Keywords: crash, testcase)
Attachments
(1 file)
|
1.93 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce:
- Visit url testcase, tap on the button
Expected result:
- tab windows open (5 of them), then close
Actual result:
- crash, os reboot
| Reporter | ||
Comment 1•13 years ago
|
||
I submitted the FirefoxOS crash reports, with the dialog at the bottom that I'm seeing after the system reboot.
I don't know where you could see those, though. My Otoro phone nr. is 12539.
Updated•13 years ago
|
blocking-basecamp: --- → ?
Updated•13 years ago
|
blocking-basecamp: ? → +
Comment 3•13 years ago
|
||
(In reply to Lawrence Mandel [:lmandel] from comment #2)
> Justin, can you take this one?
I'm trying to focus on memory usage.
Patrick, do you think you have time to look at this?
Comment 4•13 years ago
|
||
I did some tests about this bug.
1. We can reproduce this bug by just opening 5 windows at once. We don't need to close the 5 windows.
2. The crash occurs at /gfx/layer/Layers.h[1], because the argument of the method is 0x0. The caller WalkTheTree()[2] calls the method with the argument which is stored in a static map (sIndirectLayerTrees). It seems there is some function modified the map before WalkTheTree uses them. But I haven't found when the value is changed.
3. If we make program run slower, like by printing more log or disabling optimization, this bug may not be reproduced. Looks like there's a race condition.
[1] https://mxr.mozilla.org/mozilla-central/source/gfx/layers/Layers.h?rev=cf8750abee06#1593
[2] https://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/CompositorParent.cpp?rev=a79d36c9174b#485
Updated•13 years ago
|
Assignee: justin.lebar+bug → gwright
Comment 5•13 years ago
|
||
Setting priority based on triage discussions. Feel free to decrease priority if you disagree.
Priority: -- → P1
Comment 6•13 years ago
|
||
This looks like a crash in layers code, which is pretty weird. Jeff / Roc, are you willing and able to dig deeper into this?
| Assignee | ||
Comment 7•13 years ago
|
||
This crash suggests that the b2g main thread thinks a frame is visible, but we don't have a shadow tree for that frame. (Or it was destroyed.)
We can fix the crash by null-checking, but that might result in graphical artifacts from not rendering part of what the main thread wants to render. But better than crashing.
| Assignee | ||
Comment 8•13 years ago
|
||
I can't reproduce this with the above testcase, but it's not illegal for a shadow tree to have a null root so we should null-check when resolving.
Assignee: gwright → jones.chris.g
| Assignee | ||
Comment 9•13 years ago
|
||
Attachment #687329 -
Flags: review?(roc)
Attachment #687329 -
Flags: review?(roc) → review+
| Assignee | ||
Comment 10•13 years ago
|
||
Comment 11•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 12•13 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•