81336 - nsHttpAuthCache causing assertions when switching profiles

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect)

Description

[Conrad Carlen (not reading bugmail)]

After switching profiles, the assertion comes from the first line of
nsHttpAuthCache::GetCredentialsForPath(). When I put in the code to make the
HTTP handler observe profile changes, this used to work. Since then, the code in
nsHttpHandler::Observe() has changed considerably. nsHttpHandler::Observe now
calls mAuthCache->ClearAll() which destroys nsHttpAuthCache's hash table. It is
never re-initialized and so we get the assertion. Two ways to fix this:

(1) From nsHttpHandler::Observe(), instead of calling a method which destroys
the whole hash table, call something which just removes all entries from the
hash table.
(2) If the auth cache is destroyed on a "profile-before-change" notification, it
should be re-initialized so that it's usable again - probably on a
"profile-after-change" notification.

Darin, you would know best how to solve this - those are just my suggestions.

Comment 1

[Conrad Carlen (not reading bugmail)]

The assertion is bad enough but this actually causes http auth to fail after a
profile switch. Upping severity.

Comment 2

[Darin Fisher]

i thought this situation was handled... guess not.  should be an easy fix.

Comment 3

[Darin Fisher]

Attachment: should fix the problem

Comment 4

[Darin Fisher]

the fix for this bug is so trivial... i mistakenly left NS_ENSURE_TRUE's at
the top of GetCredentialsFor{Path,Domain} and SetCredentials which assert
that the auth DB exist.  yet, the code inside these functions handles the case
of a null DB.  so, the fix is just to remove the assertions.

ccarlen: can i get an r= from you on this?

Comment 5

[Conrad Carlen (not reading bugmail)]

That works. Thanks for dealing so quickly. r=ccarlen.
BTW, those NS_ENSURE_TRUEs do a lot more than assert - they assert and then bail.

Comment 6

[Gagan]

r=gagan

Comment 7

[Scott MacGregor]

rs=mscott

Comment 8

[Darin Fisher]

fix checked in

Comment 9

[John Unruh]

Verified per darin's comment.