Closed
Bug 813455
Opened 12 years ago
Closed 12 years ago
[Contacts] After deleting one contact the list is empty although you have more contacts
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: crdlc, Assigned: crdlc)
Details
Attachments
(1 file)
|
188 bytes,
text/html
|
jmcf
:
review+
arcturus
:
approval-gaia-v1+
|
Details |
This bug was introduced in here
https://github.com/mozilla-b2g/gaia/commit/39ba66ca65ec49cb0b5ab6dc5820fff5cada282b
Expected: no empty list with contacts after deleting one contact
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•12 years ago
|
||
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: user cannot view the list after deleting contact
Testing completed:
Risk to taking this patch (and alternatives if risky): No risk
Attachment #683473 -
Flags: review?(jmcf)
Attachment #683473 -
Flags: approval-gaia-master?(francisco.jordano)
|
||
Updated•12 years ago
|
Attachment #683473 -
Flags: review?(jmcf) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
added test, thanks Isma
|
||
Comment 3•12 years ago
|
||
Comment on attachment 683473 [details]
Solved
Love a bug that adds 95% of code for unit tests \o/
Attachment #683473 -
Flags: approval-gaia-master?(francisco.jordano) → approval-gaia-master+
|
|
||
Comment 4•12 years ago
|
||
r+ on my side once Cristian merges the PR I have made to make more sense for the test
https://github.com/crdlc/gaia/pull/9/files
|
|
Assignee | |
Comment 5•12 years ago
|
||
done, applied the patch, thanks
|
|
Assignee | |
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•