813490 - FB Import needs to support edit mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Jose Manuel Cantera]

For the sake of UX consistency and according to feedback received from users it is needed to implement an edit mode for Facebook import. This UI will be based on the edit mode Building Block and will provide the following functionality:

The user can select or deselect what friends are imported as contacts on her device. If an already imported friend is deselected, then that friend will be removed from the device. If the friend is linked to a local device contact, then a hard unlink will be done i.e. the friend will be removed from the device. If a not imported friend is selected, then the behavior will be the same as already implemented. 

Once the update finishes the user will return to the Contact List screen and a status message will inform of the changes performed.

Comment 1

[Jason Smith [:jsmith]]

The facebook integration component will be disappearing soon in favor of moving it under contacts per feedback I received on bug management.

Comment 2

[Marcelino Veiga Tuimil [:sonmarce]]

(In reply to Jason Smith [:jsmith] from comment #1)
> The facebook integration component will be disappearing soon in favor of
> moving it under contacts per feedback I received on bug management.

Could you explain this more in detail?

Comment 3

[Jason Smith [:jsmith]]

(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #2)
> (In reply to Jason Smith [:jsmith] from comment #1)
> > The facebook integration component will be disappearing soon in favor of
> > moving it under contacts per feedback I received on bug management.
> 
> Could you explain this more in detail?

I believe the rationale was the facebook integration piece primarily focuses on importing contacts if I'm not mistaken, so the thought was to stick facebook integration under the contacts component along with general contacts app issues.

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 683967 [details]
Patch v1

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 6

[Cristian Rodriguez (:crdlc)]

Kaze sorry for new literals but this is a new feature requested by UX and it' s needed to add them for the edit mode :(

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 683967 [details]
Patch v1

Excellen job Cristian, please merge once you get the + from reviewers

Comment 8

[Cristian Rodriguez (:crdlc)]

Stas please review the changes in locales because the functionality has been reviewed by Francisco and Jose, thanks a lot

Comment 9

[Cristian Rodriguez (:crdlc)]

all comments are implemented

Comment 10

[Fabien Cazenave [:kaze]]

Comment on attachment 683967 [details]
Patch v1

r=me for the l10n part, relying on Jose’s review to merge.
https://github.com/mozilla-b2g/gaia/commit/daa0b8be1f05fe4b7147cc528b1a5a17a4fa7d36

Comment 11

[Staś Małolepszy :stas]

Can we close this now?

Comment 12

[Cristian Rodriguez (:crdlc)]

yes