813503 - Derived searches no longer work on DXR

Status: RESOLVED WONTFIX

(Webtools Graveyard :: DXR, defect)

Description

[Schalk Neethling [:espressive]]

Quoting a user directly: "I used to love the ability to perform searches like derived:nsILoadContext, but that appears to be broken in both DAO and DMO."

It seems this might be fixed based on https://bugzilla.mozilla.org/show_bug.cgi?id=755279 but, not sure if this has been merged into the Mozilla code base of DXR as the above report was made in the last month and the referenced bug stems from June 2012.

Comment 1

[Erik Rose [:erik][:erikrose]]

derived:nsDisplayOwnLayer works. A quick test of another derived-from class that appears on the same line as the deriving class works. Derived-from classes occurring after a line break (as when a class lists multiple superclasses, one to a line, with commas between) don't seem to work when used in "derived:" searches. I'll see if I can confirm this more solidly. It's a surprising failure mode if we're really instrumenting the compiler.

Comment 2

[Erik Rose [:erik][:erikrose]]

It's not the line break that ruins it. Maybe it detects only the first superclass. Nope, second ones work. Line breaks? Nope. Does it have to do with privateness? Not that I can reproduce with a simple test case. I'll next try it on the full moz-central tree; I bet it's not even a bug anymore. (Bug 755279 might also indicate this is already fixed.)

Comment 3

[Erik Rose [:erik][:erikrose]]

Reproduced on the full moz-central tree. derived:nsILoadContext doesn't turn up nsDocShell. It should. Witness: derived:nsDocLoader turns it up.

Comment 4

[Erik Rose [:erik][:erikrose]]

And now the reproduction has mysteriously vanished. Neither query turns up anything. I notice the "types" table in SQLite has 0 rows. That would certainly do it, as the query is...

    SELECT files.path, files.icon, trg_index.text, files.ID,
    extents(trg_index.contents)
      FROM trg_index, files
     WHERE  files.ID = trg_index.id  AND EXISTS (SELECT 1 FROM types as sub, impl, types
                        WHERE  types.tname LIKE ? ESCAPE "\" 
                          AND impl.tbase = types.tid
                          AND impl.tderived = sub.tid
                          AND sub.file_id = files.ID) LIMIT ? OFFSET ?
  
    parameters 0
    u'%nsILoadContext%'
    100

The functions, impl, scopes, and variables tables are similarly empty. Hmm. Let's try building anew....

Comment 5

[Erik Rose [:erik][:erikrose]]

Let's see what's in the temp folder. If stuff got in there, see why we didn't index it into the tables.

Comment 6

[Erik Rose [:erik][:erikrose]]

Still reproducible as of 09164ea32d72438027c6a79cfe63830266207a77.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

DXR is no longer available. Searchfox is now replacing it.
See meta bug 1669906 & https://groups.google.com/g/mozilla.dev.platform/c/jDRjrq3l-CY for more details.