813522 - Remove libsoundtouch from package-manifest.in

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Frank Wein [:mcsmurf]]

See Bug 779997, libsoundtouch has been disabled for now.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 2

[Philip Chee]

Comment on attachment 683546 [details] [diff] [review]
Patch

rs=me

Comment 3

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/cc3a7263950f

Leaving open as this patch probably also needs to be pushed on Aurora.

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 683546 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: SeaMonkey build will fail
Testing completed (on m-c, etc.): Works on mozilla-central, core Bug 779997 also landed on mozilla-aurora, so this patch also needs to land on comm-aurora
Risk to taking this patch (and alternatives if risky): No risk
String changes made by this patch: -

Comment 5

[Philip Chee]

Comment on attachment 683546 [details] [diff] [review]
Patch

a=me

Comment 6

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/releases/comm-aurora/rev/f4ced9a5538e

Comment 7

[Philip Chee]

Bug 779997 Comment 42:
Patch was backed out on mozilla-central.

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Philip Chee from comment #7)
> Bug 779997 Comment 42:
> Patch was backed out on mozilla-central.

Seems nightlies were broken (XPCOM error at startup) due to that so we need to back out on our side as well ASAP.

Looking at FF's removed-files.in I could not find any reference to soundtouch and it seems it was never removed either (according to a brief look at the hg log) so I guess we really need to reverse apply the whole patch.

Comment 9

[Frank Wein [:mcsmurf]]

Backed out the patch: https://hg.mozilla.org/comm-central/rev/7f4abaaa35d7
https://hg.mozilla.org/comm-central/rev/7b787e3d6026 (two patches as merge was needed)