Closed Bug 813522 Opened 9 years ago Closed 9 years ago

Remove libsoundtouch from package-manifest.in

Categories

(SeaMonkey :: Installer, defect)

defect
Not set
normal

Tracking

(seamonkey2.16 fixed)

RESOLVED FIXED
seamonkey2.17
Tracking Status
seamonkey2.16 --- fixed

People

(Reporter: mcsmurf, Assigned: mcsmurf)

References

Details

Attachments

(1 file)

See Bug 779997, libsoundtouch has been disabled for now.
Attached patch PatchSplinter Review
Assignee: installer → bugzilla
Status: NEW → ASSIGNED
Attachment #683546 - Flags: review?(philip.chee)
Comment on attachment 683546 [details] [diff] [review]
Patch

rs=me
Attachment #683546 - Flags: review?(philip.chee) → review+
Pushed: https://hg.mozilla.org/comm-central/rev/cc3a7263950f

Leaving open as this patch probably also needs to be pushed on Aurora.
Comment on attachment 683546 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: SeaMonkey build will fail
Testing completed (on m-c, etc.): Works on mozilla-central, core Bug 779997 also landed on mozilla-aurora, so this patch also needs to land on comm-aurora
Risk to taking this patch (and alternatives if risky): No risk
String changes made by this patch: -
Attachment #683546 - Flags: approval-comm-aurora?
Comment on attachment 683546 [details] [diff] [review]
Patch

a=me
Attachment #683546 - Flags: approval-comm-aurora? → approval-comm-aurora+
Pushed: https://hg.mozilla.org/releases/comm-aurora/rev/f4ced9a5538e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.17
Bug 779997 Comment 42:
Patch was backed out on mozilla-central.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Philip Chee from comment #7)
> Bug 779997 Comment 42:
> Patch was backed out on mozilla-central.

Seems nightlies were broken (XPCOM error at startup) due to that so we need to back out on our side as well ASAP.

Looking at FF's removed-files.in I could not find any reference to soundtouch and it seems it was never removed either (according to a brief look at the hg log) so I guess we really need to reverse apply the whole patch.
Backed out the patch: https://hg.mozilla.org/comm-central/rev/7f4abaaa35d7
https://hg.mozilla.org/comm-central/rev/7b787e3d6026 (two patches as merge was needed)
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.