813533 - Private browsing doesn't work correctly after opening new window

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Enviroment:
*Firefox Nightly 20.
 http://hg.mozilla.org/mozilla-central/rev/bc69705c162d
*Intel Mac OS X 10.8

Step to reproduce:
1) open window 'A' & turn on Private-browsing.
2) close window 'A' (but keep running Firefox in dock).
3) open a new window 'B'.
4) open a URL in window 'B'.

Result:
The opened URL is recorded in browsing history.

More info:
This bug appears in Nightly 19, after http://hg.mozilla.org/mozilla-central/rev/a761bfc192b5. (Sorry, I could not report this bug immediately.)
We will need to land a patch which will fix this to aurora 19 code base.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Ensure windows opened in global private browsing mode with no parent present are still marked as private.

This got in-person r+ from ehsan, so I'm going to land it.

Comment 2

[Josh Matthews [:jdm]]

To fix this on Aurora, I'll back out bug 795556.

Comment 3

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f847258636a

Comment 4

[(no longer active)]

Josh can you please attach the backout patch for approval?  Thanks!

Comment 5

[Josh Matthews [:jdm]]

Attachment: Back out bug 795556 patch #2.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 795556
User impact if declined: Non-private windows (and associated behaviour) while in private mode in certain limited situations.
Testing completed (on m-c, etc.): Restoring previous behaviour by backing out patch that changed it.
Risk to taking this patch (and alternatives if risky): None. The code being restored ensured that all windows were correctly marked as private if PB mode was enabled.
String or UUID changes made by this patch: None.

Comment 6

[Josh Matthews [:jdm]]

Attachment: Back out bug 795556 patch #2.

Comment 7

[Josh Matthews [:jdm]]

Comment on attachment 683713 [details] [diff] [review]
Back out bug 795556 patch #2.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 795556
User impact if declined: Non-private windows (and associated behaviour) while in private mode in certain limited situations.
Testing completed (on m-c, etc.): Restoring previous behaviour by backing out patch that changed it.
Risk to taking this patch (and alternatives if risky): None. The code being restored ensured that all windows were correctly marked as private if PB mode was enabled.
String or UUID changes made by this patch: None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f847258636a

Comment 9

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Umm...  From commit log, this patch have been landed already.
But In today's nightly build (http://hg.mozilla.org/mozilla-central/rev/4f19e7fd8bea), this has not fixed yet...

Comment 10

[Josh Matthews [:jdm]]

I tried today's nightly and it works fine for me. Here are the steps I followed:

1) Enter PB session
2) Close all open windows, leaving the app open in the dock
3) Open a new window, visit an unvisited page

The new window opens to about:privatebrowsing, and the page I visit doesn't show up in the history.

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 683713 [details] [diff] [review]
Back out bug 795556 patch #2.

[Triage Comment]
Low risk backout, approving for Aurora 19.

Comment 12

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eb0aa4b2eabf

Comment 13

[(no longer active)]

Backed out: https://hg.mozilla.org/releases/mozilla-aurora/rev/fe01134efd58

Josh claims that he has a patch that actually builds:


philor
ehsan: not enough backout on aurora? needed-clobber?
dbaron
ehsan, red on aurora... oh
ehsan
philor: oh noes, that backout patch is broken
jprmc has left IRC (Input/output error)
jdm
ehsan: are you talking about the pb-related backout?
jdm
because yeah, I have a local patch which actually builds
ehsan
yeah
ehsan
good
ehsan
please land it ;)
17:09 jdm
so demanding

Comment 14

[Josh Matthews [:jdm]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e38abb2dab15

Comment 15

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Josh Matthews [:jdm] from comment #10)
> I tried today's nightly and it works fine for me. Here are the steps I
> followed:
> 
> 1) Enter PB session
> 2) Close all open windows, leaving the app open in the dock
> 3) Open a new window, visit an unvisited page
> 
> The new window opens to about:privatebrowsing, and the page I visit doesn't
> show up in the history.

I find the special case which has not been fixed yet.
So In step 3), if we opened a new window with 'click dock icon', the page I visit show up in the history.

If we opened a new window with 'dock-context-menu or menu-bar', this bug has been fixed in today's nightly.

So should I file a new bug?

Comment 16

[(no longer active)]

(In reply to comment #15)
> (In reply to Josh Matthews [:jdm] from comment #10)
> > I tried today's nightly and it works fine for me. Here are the steps I
> > followed:
> > 
> > 1) Enter PB session
> > 2) Close all open windows, leaving the app open in the dock
> > 3) Open a new window, visit an unvisited page
> > 
> > The new window opens to about:privatebrowsing, and the page I visit doesn't
> > show up in the history.
> 
> I find the special case which has not been fixed yet.
> So In step 3), if we opened a new window with 'click dock icon', the page I
> visit show up in the history.
> 
> If we opened a new window with 'dock-context-menu or menu-bar', this bug has
> been fixed in today's nightly.
> 
> So should I file a new bug?

Yes, please.  Thanks a lot!

Comment 17

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on FF 19b4 on Mac OS 10.8. I was not able to reproduce the issue mentioned by Tetsuharu in Comment 15. Is your issue from Comment 15 intermittent ?

Comment 18

[Mihai Morar, (:MihaiMorar)]

Verified fixed on FF 20.b1:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0

Comment 19

[Mihai Morar, (:MihaiMorar)]

Verified fixed on FF 20.b5