813536 - Enable OEM/Phone Manufacturer/Carrier to override prefs

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

Would it be possible for OEM/Phone Manufacturer/Carrier add a way of overriding gecko preferences during build time? I don't mean to add preferences in upstream, just an empty. That way carriers/oems/phone manufacturers could add their preferences in that file at build time. For example we (TEF) are about to start playing with building OTA updates and delivering them from TEF servers so we'll need to overwrite app.update.* preferences. Also, in the future, OEMs and other could do something like that.

See discussion at https://github.com/mozilla-b2g/gaia/pull/6304#discussion_r2136437

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

This bug is not very important at all but nom'ing for basecamp.

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: WIP

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/6551

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Not Applicable.
User impact if declined: None.
Testing completed: Tested.
Risk to taking this patch (and alternatives if risky): None.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Why don't you use custom-prefs.js ?

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Vivien Nicolas (:vingtetun) from comment #4)
> Why don't you use custom-prefs.js ?

Because of simplicity and uniformity. The OEM/PhonecManufacturer/Carrier would simply override a file at build time. Uniformity, there is already such kind of specific preference files, I mean something like {payment, ua-override}-prefs.js files so why don't use a file to allow the OEM/Phone Manufacturer/Carrier for overriding pref according its needs.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #5)
> (In reply to Vivien Nicolas (:vingtetun) from comment #4)
> > Why don't you use custom-prefs.js ?
> 
> Because of simplicity and uniformity. The OEM/PhonecManufacturer/Carrier
> would simply override a file at build time. Uniformity, there is already
> such kind of specific preference files, I mean something like {payment,
> ua-override}-prefs.js files so why don't use a file to allow the OEM/Phone
> Manufacturer/Carrier for overriding pref according its needs.

But those 2 files already have something in it. custom-prefs.js does not exists and it's whole purpose is to be customized. I just feel like we want to add a file to do something that already exists.

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Vivien Nicolas (:vingtetun) from comment #6)

This sounds about right somehow. This bug/addition was discussed here [1] so I was ahead with it. That's all. I'll resolve it as wont fix.


[1] https://github.com/mozilla-b2g/gaia/pull/6304#discussion_r2139670