813553 - [Mac OS] Firefox freezes after installing add-ons which launch a pop-up after installation

Status: VERIFIED FIXED

(WebExtensions :: General, defect)

Description

[Virgil Dicu [:virgil] [QA]]

Only occurs on Mac. Couldn't reproduce on Windows 7.
Occurs starting with Firefox 17. To look for regression range.

STR:
1. Install http://hotspotshield.ourtoolbar.com/ or ct57527.ourtoolbar.com
2. Re-launch Firefox

Actual result: No operation can be performed on Firefox. Can't close the browser either. Seems that a pop-up notification should have been launched (this works correctly in F16). A blank box is displayed instead.

Can install and use these add-ons normally in Firefox 16. 
To continue investigation.  Will provide screenshot and regression range.

Comment 1

[Virgil Dicu [:virgil] [QA]]

Attachment: Yandex Firefox add-on

There's a tiny box with a finish button in the place of the regular pop-up notifying the user that the add-on is installed successfully. The Finish button is unusable.

Comment 2

[u279076]

Virgil, can you check if the freezing happens in Firefox 17.0 build 1?

Comment 3

[u279076]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #2)
> Virgil, can you check if the freezing happens in Firefox 17.0 build 1?

Once you've done this, please also check if updating from Firefox 16.0.2 -> 17.0 on betatest also shows this problem.

Comment 4

[Virgil Dicu [:virgil] [QA]]

Attachment: Firefox 16 yandex add-on behavior

In Firefox 16, the pop-up is displayed correctly as can be seen in the screenshot.

Comment 5

[Virgil Dicu [:virgil] [QA]]

Same behavior with following add-ons:
http://incredimailmediabar2.ourtoolbar.com/
http://downloadmytoolbar.com/4shared/LP/download.html

In addition to the two already mentioned in comment 0:
http://hotspotshield.ourtoolbar.com/
http://ct57527.ourtoolbar.com/

Comment 6

[Virgil Dicu [:virgil] [QA]]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #2)
> Virgil, can you check if the freezing happens in Firefox 17.0 build 1?

I've checked with F17 beta 6 (prior to 17. RC build 1) and I can reproduce the problem there as well.

Comment 7

[u279076]

Virgil, please check 16.0.2 -> 17.0 updates on betatest to see if this reproduces after updating.

Comment 8

[Virgil Dicu [:virgil] [QA]]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #7)
> Virgil, please check 16.0.2 -> 17.0 updates on betatest to see if this
> reproduces after updating.

It doesn't reproduce after upgrading. Seems the pop-up is displayed only after installation.

STR used:
1. Install http://ct57527.ourtoolbar.com/ in F16.0.2
   - add-on is installed correctly
   - notification is displayed 
   - browser functional
2. Upgrade to 17 RC build 2 using betatest channel
   - no notification displayed 
   - no freezes, can use any operation within Firefox

Comment 9

[Virgil Dicu [:virgil] [QA]]

Regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=812ea773f166&tochange=8c85c83068e7

Last good nightly: 2012-08-18
First bad nightly: 2012-08-19

Comment 10

[u279076]

Maybe bug 740289 or bug 704751?

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

All the affected add-ons mentioned here are toolbar add-ons built on Conduit Community Toolbar: http://toolbar.conduit.com/

If those are indeed the only affected add-ons, then I'd call this a bug in Conduit's framework.

Either way, I very much doubt this is an Add-ons Manager bug.

Comment 12

[Shiran Conduit]

Hi,

Issue is resolved in toolbar version 3.16.0.3

Thanks
Shiran

Comment 13

[u279076]

(In reply to Shiran Conduit from comment #12) 
> Issue is resolved in toolbar version 3.16.0.3

Virgil, please confirm.

Comment 14

[Virgil Dicu [:virgil] [QA]]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #13)
> (In reply to Shiran Conduit from comment #12) 
> > Issue is resolved in toolbar version 3.16.0.3
> 
> Virgil, please confirm.

All good now. Used the two add-ons in comment 0 in Firefox 18 b3. Can see the pop-up being displayed.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:18.0) Gecko/20100101

Comment 15

[u279076]

Thanks Virgil, can you also confirm against Firefox 17.0.1?

Comment 16

[Virgil Dicu [:virgil] [QA]]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #15)
> Thanks Virgil, can you also confirm against Firefox 17.0.1?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20100101 Firefox/17.0

All good on Firefox 17 and Nightly as well. Version 3.16.0.3 of the toolbar.

Comment 17

[u279076]

Thanks Virgil, marking this verified fixed.