81356 - Editor needs to call ForceCompositionEnd() for IME at losing input focus

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Masaki Katakai]

In nsTextEditorFocusListener::Blur(), editor should call ForceCompositionEnd()
if imeEditor exists to inform "focus is leaving from this widget" to IME.

IME wants to know the timing by ResetInputState(), then IME has to
do reset the state of IME engine, clear the composition text, then call
NS_COMPOSITION_END to close the composition event.

Yes, I can see nsTextEditorMouseListener::MouseClick() calls ForceCompositionEnd(),
but it's not enough because the event happens on destination widget, there is no way
to send composition event to *original* widget in ResetInputState().

Comment 1

[Masaki Katakai]

Attachment: proposed patch

Comment 2

[Masaki Katakai]

Attachment: sorry, ignore the first attachment, this is correct one.

Comment 3

[rubydoo123]

assigning to sfraser for review of patch

Comment 4

[Simon Fraser [no longer active]]

That patch looks pretty good.

Comment 5

[Masaki Katakai]

Thank you very much for review, 

But can you wait check-in? because I have to verify the
patch will not break current ResetInputState() codes of
all platforms. I'll ask each platform owner to verify.

Comment 6

[kinmoz]

r/sr=[e-mail] as long as testing has been done to ensure there are no 
IME related regressions on other platforms.

Comment 7

[kinmoz]

One other question, some platforms pop up a seperate window when IME is 
activated will this generate an unexpected Blur()?

Comment 8

[Masaki Katakai]

Hi Kin,

Yes, some of Linux IME invokes separate window to display candidates.
I put the codes long ago not to commit at the case (for the original
problem that ResetInputState() is called when the window gets focus
at dismissing candidate window).

I understand Windows IME will not grab any input focus -> it should work
But I need to check Mac, and other platforms.

Comment 9

[Simon Fraser [no longer active]]

Is this ready to go in? You have until midnight tomorrow :)

Comment 10

[Masaki Katakai]

Sorry, I haven't got results on Windows and Mac yet.

For safety, should we move to 0.9.2?

Comment 11

[Simon Fraser [no longer active]]

Yes

Comment 12

[Kathleen :Brade]

it looks ok to me other than missing the space after the "if"

Comment 13

[Simon Fraser [no longer active]]

Masakai: what's the status on this bug? Have you tested Windows and Mac?

Comment 14

[Masaki Katakai]

Sorry for late.

Ready to check in for 0.9.2. I got no problem from Windows, Mac, UNIX side.
(See bug 81360, bug 81365 abd bug 81364)

Comment 15

[Masaki Katakai]

Sorry again. I found crash problem on Linux with this fix. Please wait
until I can provide fix for widget/gtk.

Comment 16

[Masaki Katakai]

*** Bug 81365 has been marked as a duplicate of this bug. ***

Comment 17

[Masaki Katakai]

*** Bug 81364 has been marked as a duplicate of this bug. ***

Comment 18

[Masaki Katakai]

I blieve this patch itself is correct fix but gtk has a problem
of bug 81360. No problems for windows and mac.

Comment 19

[Simon Fraser [no longer active]]

So should this be checked in?

Comment 20

[Simon Fraser [no longer active]]

On second thoughts: reassigning to [e-mail]. When this is ready to 
go, give it back to me.

Comment 21

[Masaki Katakai]

Sorry for slow progress.

I finally have fixed the GTK problem (bug 81360). So ready to check in
the patch for Editor.

Simon, can you take this?

Reassigned to Simon.

Comment 22

[Masaki Katakai]

Editor folks,

Is it possible to check in after 0.9.5?

Thanks.

Comment 23

[Kathleen :Brade]

I'll take this bug from Simon since he isn't doing much editor stuff anymore.
I'd like ftang or someone on his team to review this in addition to myself and a 
super-reviewer.

Comment 24

[Frank Tang]

Comment on attachment 34920 [details] [diff] [review]
sorry, ignore the first attachment, this is correct one.

r=ftang

Comment 25

[Frank Tang]

add yokoyama to the cc list. This could also cause the Chinese IME type abc to
cba issue. We have another work around for that already in the branch. 

brade- please ask yokoyama for future IME related review. Katakai know IME code
prety well aslo (he and tajima wrote the GTK IME code)

Comment 26

[Simon Fraser [no longer active]]

Comment on attachment 34920 [details] [diff] [review]
sorry, ignore the first attachment, this is correct one.

sr=sfraser

Comment 27

[Kathleen :Brade]

this fix was checked in (revision 1.192)

Comment 28

[sujay]

Masaki, please verify this bug when you get chance..let us know if it is fixed.

thanks.

Comment 29

[Masaki Katakai]

Thank you very much.

I have verified the fix on 1118 nightlies on both Windows and Linux.

Comment 30

[sujay]

verified.