The default bug view has changed. See this FAQ.

Permanent orange: various oranges related to plugins

RESOLVED FIXED in Thunderbird 20.0

Status

Thunderbird
Testing Infrastructure
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

({intermittent-failure})

Trunk
Thunderbird 20.0
x86
All
intermittent-failure

Thunderbird Tracking Flags

(thunderbird18 fixed, thunderbird19 fixed, thunderbird-esr1718+ fixed)

Details

Attachments

(1 attachment)

We've started seeing the following Mozmill failures across the board:

TEST-START | /home/cltbld/talos-slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | test_unknown_plugin_notification_inline
Step Pass: {"function": "controller.click()"}
Step Pass: {"function": "controller.waitFor()"}
Test Failure: The plugin install status should have been ready: 'ready' != 'null'.
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_inline
TEST-START | /home/cltbld/talos-slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | test_unknown_plugin_notification_bar
Step Pass: {"function": "controller.click()"}
Test Failure: Timeout waiting for the content tab to open
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_bar

TEST-START | /home/cltbld/talos-slave/test/build/mozmill/content-tabs/test-plugin-blocked.js | test_blocklisted_plugin_notification
Step Pass: {"function": "controller.click()"}
Test Failure: Timeout waiting for alert
TEST-START | /home/cltbld/talos-slave/test/build/mozmill/content-tabs/test-plugin-blocked.js | teardownTest
TEST-PASS | /home/cltbld/talos-slave/test/build/mozmill/content-tabs/test-plugin-blocked.js | test-plugin-blocked.js::teardownTest
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/content-tabs/test-plugin-blocked.js | test-plugin-blocked.js::test_blocklisted_plugin_notification

TEST-START | /home/cltbld/talos-slave/test/build/mozmill/message-header/test-phishing-bar.js | test_phishing_bar_for_eml_attachment
Test Failure: Notification bar is collapsed!
WARNING: gsignal.c:3078: signal name `selection_changed' is invalid for instance `0x7f8afe0b70b0': 'glib warning', file ../../../../mozilla/toolkit/xre/nsSigHandlers.cpp, line 126

(thunderbird-bin:3104): GLib-GObject-WARNING **: gsignal.c:3078: signal name `selection_changed' is invalid for instance `0x7f8afe0b70b0'
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/message-header/test-phishing-bar.js | test-phishing-bar.js::test_phishing_bar_for_eml_attachment
I think we're going to have to port some work from bug 800018 in our fork of plugins.js.
Whiteboard: [tb-orange]
Created attachment 683721 [details] [diff] [review]
Patch v1

Ported over the relevant parts of 800018. Didn't copy over any of the click-to-play stuff, since, well, we don't seem to really have the front-end support for click-to-play yet.

content-tabs tests all pass with this patch.
Attachment #683721 - Flags: review?(mbanner)
Comment on attachment 683721 [details] [diff] [review]
Patch v1

Looks good, please can you file a follow-up on porting click-to-play.
Attachment #683721 - Flags: review?(mbanner) → review+
Comment on attachment 683721 [details] [diff] [review]
Patch v1

Review of attachment 683721 [details] [diff] [review]:
-----------------------------------------------------------------

I knew I forgot something...

::: mail/base/content/plugins.js
@@ +132,5 @@
>                                true);
>    },
>  
> +  // Helper to get the binding handler type from a plugin object
> +  _getBindingType : function(plugin) {

This function is throwing strict warnings that it isn't always returning a type. The two returns just need to return null.
I landed this with the added nulls:

https://hg.mozilla.org/comm-central/rev/6a818f090e03

I think we'll need a separate bug for the test-phishing-bar.js, but we'll see what the tree does after it cycles for this fix.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Keywords: intermittent-failure
Whiteboard: [tb-orange]
Comment on attachment 683721 [details] [diff] [review]
Patch v1

The bug that originally broke trunk got ported to mozilla-aurora, beta, and the ESR channel - which means we're seeing oranges across the board on comm-aurora/beta/esr.
Attachment #683721 - Flags: approval-comm-esr17?
Attachment #683721 - Flags: approval-comm-beta?
Attachment #683721 - Flags: approval-comm-aurora?
Attachment #683721 - Flags: approval-comm-esr17?
Attachment #683721 - Flags: approval-comm-esr17+
Attachment #683721 - Flags: approval-comm-beta?
Attachment #683721 - Flags: approval-comm-beta+
Attachment #683721 - Flags: approval-comm-aurora?
Attachment #683721 - Flags: approval-comm-aurora+
tracking-thunderbird-esr17: --- → 18+
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/f096f9ef211d
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/0350bdb2d166
status-thunderbird18: --- → fixed
status-thunderbird19: --- → fixed
Target Milestone: --- → Thunderbird 20.0
https://hg.mozilla.org/releases/comm-esr17/rev/d177ab5d0482
status-thunderbird-esr17: --- → fixed
You need to log in before you can comment on or make changes to this bug.