813676 - While on a call a long press on 0 should not generate a '+' since the DTMF sent will always be 0

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Carol Yang [:cyang]]

In a GCF test for DTMF, the test equipment expects DTMF '0' to be sent. If a short press on '0' is done, Stop DTMF is sent immediately and the TC fails. The '0' must be pressed a little longer but that causes DTMF '+' to be sent.

There is no option to tweak the test equipment as this is a GCF test setup. Can the keyboard be fixed in anyway to accommodate this?

Comment 1

[Andreas Gal :gal]

Daniel, this is your team I think. Can you guys take this?

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Carol: I don't understand comment 0.

It sounds like you are potentially describing two problems.

1. While on a call, pressing the '0' for a very short time doesn't actually send the
   DTMF tone for '0'.
2. While on a call, pressing the '0' for a longer time displays a '+' sign rather
   than a '0' in the UI and also sends the DTMF tone for '+' rather than '0'.

Is that accurate?

If so, could you file a separate bug on problem number 1 and we'll let this bug deal with problem number 2 (since that's the problem that the summary is talking about).

Regarding problem number 2:
Is it just the UI that is displaying a '+'? Or does the UI show the '+' but there's still the DTMF tone for '0' being sent?

Is there even such a thing as a DTMF tone for '+'? I wouldn't have thought so.

If we do in fact send a '+', does that mean that we first send the DTMF tone for a '0' but after a short period of time the '0' tone turns into a '+' tone?

Comment 3

[Daniel Coloma:dcoloma]

Adding Maria so she can assign an engineer, but concur with Jonas in comment 2 that before addressing this we need a clearer description about what the bug is.

Comment 4

[Carol Yang [:cyang]]

Jonas- You're right, I do believe there are two parts to this.

I'm adding Phil as he's the new owner of this on our side to answer your questions. We'll be sure to open another bug for #1 if need be.

Comment 5

[pgravel]

>Regarding problem number 2:
>Is it just the UI that is displaying a '+'? Or does the UI show the '+' but there's still the DTMF tone for '0' being sent?
>
>Is there even such a thing as a DTMF tone for '+'? I wouldn't have thought so.

I ran a quick test and it seems that while the UI displaying '+', it is still sending the DTMF tone for '0'.
I will need to re-run the GCF test with the additional debug logs to ensure that the behavior is the same as on my device.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Thanks. Not convinced this is a blocker then. But over to gaia team to triage since this is purely a front-end bug.

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Nice catch! It is true we are not controlling the long "0" clicking during a call and consequently a "+" is displayed instead of "0". On the other hand, it is true that the tone is sent :-) Basically, what I will do is to deactivate the long "0" clicking listener so only the 0 is shown.

I have a minor question for someone of the UX team. Would you like me to remove the "+" shown next to the "0" when the keypad is shown during a call since it does not apply at all? Thanks!

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

Comment 9

[Misty Byrd]

This issue fixed for  device Ungia; build #20130103070201 v.1