Closed
Bug 813823
Opened 12 years ago
Closed 12 years ago
AudioManager reports unknown status when inserting headphone or headset.
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vliu, Assigned: vliu)
Details
Attachments
(1 file, 1 obsolete file)
2.27 KB,
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
When I tried to insert headset or headphone, NotifyHeadphonesStatus in AudioManager() reported "unknown" state. It should be fixed.
Assignee | ||
Updated•12 years ago
|
Summary: AudioManager reports wrong status when inserting headphone or headset. → AudioManager reports unknown status when inserting headphone or headset.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → vliu
Assignee | ||
Comment 1•12 years ago
|
||
Hi mwu, WIP V1 is attached. Please review it. Besides this patch, I found the name of this event headphones-status-changed seems easy confused because we have headset and headphone status in it. Does this event should be renamed? If yes, what name you suggested? Thanks.
Attachment #683837 -
Flags: review?(mwu)
Comment 2•12 years ago
|
||
Comment on attachment 683837 [details] [diff] [review] WIP V1. r=mwu Review of attachment 683837 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/AudioManager.cpp @@ +28,5 @@ > > #define LOG(args...) __android_log_print(ANDROID_LOG_INFO, "AudioManager" , ## args) > > #define HEADPHONES_STATUS_CHANGED "headphones-status-changed" > +#define HEADPHONES_STATUS_ON NS_LITERAL_STRING("on").get() HEADPHONES_STATUS_ON should never occur. Let's remove this.
Updated•12 years ago
|
Attachment #683837 -
Flags: review?(mwu)
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Michael Wu [:mwu] from comment #2) > Comment on attachment 683837 [details] [diff] [review] > WIP V1. r=mwu > > Review of attachment 683837 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/system/gonk/AudioManager.cpp > @@ +28,5 @@ > > > > #define LOG(args...) __android_log_print(ANDROID_LOG_INFO, "AudioManager" , ## args) > > > > #define HEADPHONES_STATUS_CHANGED "headphones-status-changed" > > +#define HEADPHONES_STATUS_ON NS_LITERAL_STRING("on").get() > > HEADPHONES_STATUS_ON should never occur. Let's remove this. Hi mwu, Please review this patch. Thanks.
Attachment #683837 -
Attachment is obsolete: true
Attachment #685449 -
Flags: review?(mwu)
Updated•12 years ago
|
Attachment #685449 -
Flags: review?(mwu) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4542314559d8
Keywords: checkin-needed
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4542314559d8
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•