813866 - Videos Do Not Appear in Reverse Date Order

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Richard A Milewski[:richard]]

The order of videos is not in reverse date order according to the date set on the data edit page.

Videos that are not edited after initial creation appear in the correct order (I think).  But those whose dates have been edited do not.

There are also inconsistencies in how time zones are treated on re-edit.

Changing a video's status from Schedule back to Inititated causes it to appear twice in the Event Manager.  Once in the items needing attention and once in the Archived videos section.  Control-Shift-R has no effect on this.

Comment 1

[Peter Bengtsson [:peterbe]]

It's not so easy.

The current functionality is that it's sorted by archive_time but the dates shown are the start_times. That's why it appears to be unsorted. 

Whichever way we go the right thing to do is to display the same date attribute we sort by. So sort by archive_time and show archive_time or sort by start_time and show start_time. 

Thing is, start_time is when the actual events actually happen in real life. That's the natural chronological order. However, the page is all about when events appear on the page. Like a newspaper might actually write an article at one time but publish it a different time. 

I can't make up my mind which is the "best" approach. If it was a newspaper we'd obviously sort by publication date and not when it was written. However, unlike a newspaper we, in the case of Air Mozilla, actually *care* about *when* the event happened. 

What do you think?

Comment 2

[Peter Bengtsson [:peterbe]]

Note-to-self: We've talked about this and decided to sort by start_time

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/edab8f9230ecb136685ad143428649998dff807b
bug 813866 - sort by start_time

Comment 4

[Peter Bengtsson [:peterbe]]

Please test on air-dev.