Closed
Bug 813913
Opened 12 years ago
Closed 11 years ago
WebRTC signaling code doesn't yet build on Android
Categories
(Core :: WebRTC: Signaling, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: gcp, Assigned: gcp)
References
Details
(Whiteboard: [WebRTC] [blocking-webrtc-] [qa-])
Attachments
(1 file, 3 obsolete files)
Fix WebRTC signaling to build on Android.
Assignee | ||
Updated•12 years ago
|
Attachment #683943 -
Attachment is patch: true
Updated•12 years ago
|
Priority: -- → P2
Whiteboard: [WebRTC] [blocking-webrtc-]
Assignee | ||
Comment 1•12 years ago
|
||
So, in order to get around gyp's lets-not-compile-_linux-on-android "feature" I made a seperate android copy of the sourcedir and fixed things in there instead of adding #ifdef ANDROID fixes in the Linux one.
Attachment #683943 -
Attachment is obsolete: true
Assignee | ||
Comment 2•12 years ago
|
||
Some extra cleanups.
Attachment #686603 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #686612 -
Flags: review?(dmose)
Attachment #686612 -
Flags: feedback?(ted)
Comment 3•12 years ago
|
||
Comment on attachment 686612 [details] [diff] [review] Patch 1. v3. Fix signaling code on Android Review of attachment 686612 [details] [diff] [review]: ----------------------------------------------------------------- I didn't really look at anything but the gyp file here. ::: media/webrtc/signaling/signaling.gyp @@ +201,5 @@ > > 'cflags_mozilla': [ > ], > }], > + ['OS=="android"', { Same as with nrappkit, you should be able to fold this into the Linux case.
Attachment #686612 -
Flags: feedback?(ted) → feedback-
Assignee | ||
Comment 4•12 years ago
|
||
Incorporate review comments.
Attachment #686612 -
Attachment is obsolete: true
Attachment #686612 -
Flags: review?(dmose)
Attachment #690439 -
Flags: review?(dmose)
Comment 5•12 years ago
|
||
Comment on attachment 690439 [details] [diff] [review] Patch 1. v4. Fix signaling code on Android Carrying forward feedback+ from ted. r+ from me on the .gyp file changes, and, after some discussion with jesup and ehugg, the duplication of the linux files to android versions. rs=dmose for the duplication changes.
Attachment #690439 -
Flags: review?(dmose)
Attachment #690439 -
Flags: review+
Attachment #690439 -
Flags: feedback+
Comment 6•12 years ago
|
||
Try server run started: https://tbpl.mozilla.org/?tree=Try&rev=4a4098b0c768 As I type this, I realize that this may not be testing quite the right thing if's testing against mozilla-central, since I've just moments ago, checked in the prereq patch to mozilla-inbound, which means that the prereq patch won't yet have been uplifted to m-c. Unfortunately, I have to run out the door, so I can't investigate this further right now.
Comment 7•12 years ago
|
||
Looking at the Try page more closely, the Try server pulls from mozilla-inbound, so the right thing is being built.
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a02a0f64ee61
Updated•11 years ago
|
Attachment #690439 -
Flags: checkin+
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a02a0f64ee61
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Updated•11 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-] [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•