813925 - Properly pluralize strings in all apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Staś Małolepszy :stas]

Because of the limitations of our l10n infrastructure we need to add all 6 plural cases to any string that wants to use plurals.  See https://wiki.mozilla.org/L10n:B2G/Developers#Plurals.

So instead of this:

minutesAgo={[ plural(m) ]}
minutesAgo[zero] = just now
minutesAgo[one] = a minute ago
minutesAgo[other] = {{m}} minutes ago

we need this:

minutesAgo={[ plural(m) ]}
minutesAgo[zero] = just now
minutesAgo[one] = a minute ago
minutesAgo[two] = {{m}} minutes ago
minutesAgo[few] = {{m}} minutes ago
minutesAgo[many] = {{m}} minutes ago
minutesAgo[other] = {{m}} minutes ago

I'll have a patch shortly.

Comment 1

[Staś Małolepszy :stas]

Actually, let me re-purpose this bug and fix this across the board.

Comment 2

[Staś Małolepszy :stas]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6549

Pointer to Github pull-request

Comment 3

[Staś Małolepszy :stas]

We need this for the string freeze.  This fixes all of English-centric occurrences of plural implementation.

Comment 4

[Fabien Cazenave [:kaze]]

Comment on attachment 683961 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6549

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: none
Testing completed: manual
Risk to taking this patch (and alternatives if risky): none

Comment 5

[Staś Małolepszy :stas]

https://github.com/mozilla-b2g/gaia/commit/3469ff3badbabc1fc885ff957d794d4ca4d1ab68