813934 - [B2G] Marionette touch swipe is inconsistent

Status: RESOLVED WORKSFORME

(Remote Protocol :: Marionette, defect)

Description

[Zac C (:zac)]

Attachment: Gallery flick test case

I am having not much luck using marionette flick method to swipe navigate through gallery items in the Gaia gallery.

I've tried several different variations of duration, swipe distance (back/forward) and so on but the flick action always starts but the new image will get 'stuck' somewhere between the transition. It's as if the transform process is cancelled and the image gets stuck halfway through the transform.

It doesn't get stuck in the same place every time, either.

Comment 1

[Zac C (:zac)]

Yes I agree this is a valid major severity.

We'll need flick a lot in the future.

Comment 2

[Zac C (:zac)]

I have renamed this to be more generic and hopefully catch all cases.

We're suffering this in several apps/test cases:
Homescreen swipe
Cards view (ie kill app)
Gallery

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

fyi, I've been pulled away from this bug, but when I was investigating it, the 'mouseup' event wouldn't be triggered from the synthetic gestures lib. Right before mouseup code (https://hg.mozilla.org/mozilla-central/file/4be7dbc93bba/testing/marionette/client/marionette/touch/synthetic_gestures.js#l507), we stop execution. I didn't have a chance to investigate further.

Comment 4

[James Lal [:lightsofapollo]]

I will give this a shot this week.

Comment 5

[James Lal [:lightsofapollo]]

OK, I had a very similar issue. Synthetic gesture takes an element but looks up whatever its in the path of that element to emit events on (as it changes coordinates it changes the target element). I suspect the coordinates are off a bit in the test-case or there is a lag between the test and the element itself.

If we where to literally "drag" the element as we move (as I suspect is happening in gallery) it probably makes this worse.

Comment 6

[David Flanagan [:djf]]

(In reply to James Lal [:lightsofapollo] from comment #5)
> OK, I had a very similar issue. Synthetic gesture takes an element but looks
> up whatever its in the path of that element to emit events on (as it changes
> coordinates it changes the target element). I suspect the coordinates are
> off a bit in the test-case or there is a lag between the test and the
> element itself.
> 

Hmm. For touch events, the target shoudl always be the same as the target of the touchstart event.  So if it is doing this for touch events, that might be the bug.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

I believe the relevant code is in http://hg.mozilla.org/mozilla-central/file/a3effbaa10bb/testing/marionette/client/marionette/touch/synthetic_gestures.js

Comment 8

[David Flanagan [:djf]]

Try setting touchSupported to true on line 583, so that it sends touch events. Right now it is sending mouse events for all swipes, not just mouseswipe()

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Gallery flick test case

Is this bug still valid? I was able to get the attached test case to pass.

Comment 10

[Zac C (:zac)]

That test case works and so does another one I have for the home page. It may not work for everything but it's a big improvement so far.

I wish we could say when this started working.