813957 - http://jqueryui.com site is slow after updating to version 17 and only with HWA enabled

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[godotcg-rg]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.64 Safari/537.11

Steps to reproduce:

Went to jqueryui.com
Tried again after disabling all add-ons and plugins and having restarted Firefox.
Hardware : laptop with core i7 2.8GHz, ssd, 4Go, is healthy


Actual results:

Site loads and Firefox hangs.
Scrolling is almost impossible.
Clicking in the page multiple times produces "Firefox doesn't respond" message in the window bar.
Trying to close the tab takes around 6 seconds.

Other sites I visited since the update are ok.
I have another computer with Firefox updated to version 17 and browsing the site is fluid.


Expected results:

jqueyui.com loads and I can scroll and browse the site.

Comment 1

[Matthias Versen [:Matti]]

Are you sure that http://jqueyui.com is the right URL ?
That looks like a domain used by a domain grabber

Comment 2

[godotcg-rg]

(In reply to Matthias Versen (Matti) from comment #1)
> Are you sure that http://jqueyui.com is the right URL ?
> That looks like a domain used by a domain grabber

Sorry, I made a typo in the "Expected results" section, the URL should be http://jqueryui.com

Comment 3

[Matthias Versen [:Matti]]

Reporter:
Can you please test again in the firefox safemode (help/restart with addons disabled).
The intention is not to test without addons but without hardware acceleration.

Can you please post the graphic section (not everything) from about:support of the affected and not affected system ?

I can confirm that the page lags with hwa and is fast without (http://pastebin.mozilla.org/1951342)

Comment 4

[godotcg-rg]

Indeed safemode or disabling HWA in "Options > Advanced" solves it.

Graphic section : http://pastebin.mozilla.org/1951357

The hwa is not active on the other machine where I tested (it's a virtual machine). That's why it didn't have the problem.

Comment 5

[godotcg-rg]

Graphics section when HWA is active : http://pastebin.mozilla.org/1951365

Comment 6

[VEG]

My Firefox completely hangs on jqueryui.com now. Sometimes I can close the browser only by killing the process firefox.exe.
I found cause of the problem. It's this CSS rule:

hr.dots {
	height: 10px;
	background-color: #eee;
	background:
		radial-gradient(circle, #eee 1px, transparent 0),
		radial-gradient(circle, #ddd 1px, #eee 1px) 1px 1px;
	background:
		-webkit-radial-gradient(circle, #eee 1px, transparent 0),
		-webkit-radial-gradient(circle, #ddd 1px, #eee 1px) 1px 1px;
	background:
		-moz-radial-gradient(circle, #eee 1px, transparent 0),
		-moz-radial-gradient(circle, #ddd 1px, #eee 1px) 1px 1px;
	background:
		-o-radial-gradient(circle, #eee 1px, transparent 0),
		-o-radial-gradient(circle, #ddd 1px, #eee 1px) 1px 1px;
	background-size:3px 3px;
	border: none;
}

This rule is used on all pages. I've fixed problem by this CSS for Stylish:

@-moz-document domain('jqueryui.com')
{
    hr.dots { background-image: none !important; background-color: gray !important; }
}

Comment 7

[VEG]

P.S. Firefox 17, Windows 7 SP1 x86, Pentium Dual Core T4200 2.0GHz, 3GB RAM
The file with the problematic CSS rule:
http://jqueryui.com/web-base-template/themes/jquery/css/base.css?v=1

Comment 8

[godotcg-rg]

Is this a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=632324 ?

Comment 9

[VEG]

Maybe. The previous version just a bit slow on jqueryui.com, but Firefox 17 completely hangs on the same situation. I think it's important to fix it as soon as possible.

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: testcase

Ugh.  At one point I really wanted fully declarative graphics, but they're expensive to render :p

Given background-size: 3px 3px, we really should be caching this.  Is there a plan to create a generic pattern cache for non-image patterns?  Convert them to images if they're within some size threshold and if the pattern flags are the same...

Attached testcase just renders this.  It hangs the browser on my Win7 box for a good 5 seconds or so on page load and any rerender.

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(Looks like we do have a gradient cache; is it just not triggering?)

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to godotcg-rg from comment #8)
> Is this a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=632324 ?

If this is a dupe, then this is a long standing issue and we would not track.  We'll consider a low-risk uplift nomination when one is available though.

Please renominate if this is not a dupe, the regression is recent (16/17) and it is going to affect a large population of users or websites.

Comment 13

[godotcg-rg]

I don't think this is a dupe of 632324.
Evgeny is right. I visited jqueryui.com with Firefox 16 (and 15) and I never felt something was wrong. For sure it didn't hang before Firefox 17.

Comment 14

[VEG]

Developers of jqueryui.com changed
<code>background: radial-gradient(circle, #eee 1px, transparent 0), radial-gradient(circle, #ddd 1px, #eee 1px) 1px 1px;</code>
to
<code>background-image: url("../images/gauze.png");</code>
Now jqueryui.com doesn't hang in Firefox. But I think that it should be fixed anyway.

Comment 15

[godotcg-rg]

https://bugzilla.mozilla.org/show_bug.cgi?id=823147 may have solved this but I'm note able to confirm.

Comment 16

[Mayank Bansal]

on the given URL, i dont see any slowdown with HWA.
In the attached testcase, i dont see any slowdown with HWA.

Comment 17

[Mike Taylor [:miketaylr]]

Based on Comment 16, let's close this as WORKSFORME. It's possible Bug 823147 fixed this.